bender icon indicating copy to clipboard operation
bender copied to clipboard

`flist` and `flist-plus` documentation

Open colluca opened this issue 1 year ago • 2 comments

Do I understand correctly, that the flist command outputs a whitespace-separated filelist (as could be used e.g. in Makefile prerequisites) and the flist-plus command now outputs what flist previously did as described in the README?

If so, I would open a PR to update the README accordingly.

colluca avatar Aug 06 '24 12:08 colluca

So, with some review, the previous flist command generated a file list with +incdir+s, as illustrated here: https://github.com/pulp-platform/bender/blob/v0.27.4/src/cmd/script.rs#L707-L750

The current version only generates a file list, as far as I know separated with newlines (see https://github.com/pulp-platform/bender/blob/v0.28.1/src/script_fmt/flist.tera), while flist-plus generates a file list with +incdir+s and +define+s at the start, as illustrated in the new template format here: https://github.com/pulp-platform/bender/blob/v0.28.1/src/script_fmt/flist-plus.tera . Ultimately, the old format is a mix of the new formats, where the new formats are more clearly separated between a basic file list and a tool-ready file list.

Feel free to propose a PR, either modifying the command or modifying the readme.

micprog avatar Aug 06 '24 13:08 micprog

Great, thanks :) Will open a PR to update the README.

colluca avatar Aug 06 '24 13:08 colluca

Closing this as solved in https://github.com/pulp-platform/bender/pull/178.

colluca avatar Sep 26 '24 12:09 colluca