ara icon indicating copy to clipboard operation
ara copied to clipboard

[hardware] Floating-Point classify, division, sqrt

Open mp-17 opened this issue 2 years ago • 6 comments

This PR depends on https://github.com/pulp-platform/ara/pull/133 and, for ease of merging, on https://github.com/pulp-platform/ara/pull/131 as well

Add floating-point classify, division, sqrt instructions, delayed because of the FPU. I updated the CVA6 submodule, which now points to the modified FPU, able to classify as expected. Moreover, the bug related to the synchronization of the FPU lanes is now solved.

Changelog

Added

  • Vector floating-point classify instruction (vfclass)
  • Vector floating-point divide instructions (vfdiv, vfrdiv)
  • Vector floating-point square-root instruction (vfsqrt)

Checklist

  • [x] Automated tests pass
  • [x] Changelog updated
  • [x] Code style guideline is observed
  • [x] No frequency degradation

mp-17 avatar Jan 19 '22 11:01 mp-17

Ready for review when the automated tests pass! ;-)

mp-17 avatar Jan 19 '22 16:01 mp-17

Delaying the merge until the backend issues with the divider are solved.

suehtamacv avatar Feb 10 '22 09:02 suehtamacv

Any chance we can replace FPNew's divider with the new divider everyone is talking about? :smirk:

suehtamacv avatar Jul 27 '22 17:07 suehtamacv

Any chance we can replace FPNew's divider with the new divider everyone is talking about? smirk

Indeed, it's in the pipeline! ;-)

mp-17 avatar Aug 02 '22 09:08 mp-17

Any chance we can replace FPNew's divider with the new divider everyone is talking about? smirk

Unluckily, it is 32-bits only :-/

mp-17 avatar Aug 07 '22 15:08 mp-17

Backend problems are solved now, let's merge this as soon as the tests pass ;-)

mp-17 avatar Aug 15 '22 10:08 mp-17

@suehtamacv, we can merge this now, right?

mp-17 avatar Sep 26 '22 15:09 mp-17