ief icon indicating copy to clipboard operation
ief copied to clipboard

bugfix in video demo and feature in visualization

Open TheTesla opened this issue 9 years ago • 4 comments

bugfix: autodetect opencv major version - variable is string must be converted in int; feature: RGB->BGR convertion optional in plot_pose_stickmodel_cv2mat()

TheTesla avatar Mar 10 '16 13:03 TheTesla

I will have a look at it this week. Sorry for the delay in response.

pulkitag avatar Mar 17 '16 13:03 pulkitag

Hi Stefan,

A couple of things before I merge this:

  1. Can you make the python code so that each line is atmost 80 characters long? (i.e. break long lines into multiple lines). This makes code more readable.
  2. In the class PoseIEF - can you please include a short description of the new functions and how they should be used?
  3. Regarding naming convention: Lets follow this to be consistent with rest of the code (https://github.com/pulkitag/ief/wiki/Contributing)

pulkitag avatar Apr 01 '16 05:04 pulkitag

I am doing the work to prepare my contributions for your needs. Should I use 4 or 8 space for indentation? Will you provide the code for training?

TheTesla avatar Oct 14 '16 14:10 TheTesla

4 space. Hoping to release the training code in Dec.

On Oct 14, 2016 3:06 PM, "Stefan Helmert" [email protected] wrote:

I am doing the work to prepare my contributions for your needs. Should I use 4 or 8 space for indentation? Will you provide the code for training?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/pulkitag/ief/pull/5#issuecomment-253809504, or mute the thread https://github.com/notifications/unsubscribe-auth/AETXxoq8dCmRpSnQf3M7UHHZKS71uK5Uks5qz4xSgaJpZM4Httpd .

pulkitag avatar Oct 16 '16 10:10 pulkitag