flask-oidc icon indicating copy to clipboard operation
flask-oidc copied to clipboard

Itsdangerous replacement with PyJWT

Open gerwout opened this issue 2 years ago • 14 comments

Newer versions of Itsdangerous (i.e. 2.1.1) no longer have support for JWT encoding and/or decoding (https://github.com/pallets/itsdangerous/blob/d1c85670cce70d81f9949619434daf8c0b9cd37e/src/itsdangerous/jws.py#L23-L30). This is a breaking change for flask-oidc. This PR replaces the itsdangerous functionality with PyJWT.

gerwout avatar Mar 24 '22 13:03 gerwout

Very nice.

billsteve avatar May 17 '22 09:05 billsteve

It would be great to get this merged and released.

palewire avatar Jun 08 '22 16:06 palewire

Is there anything needed to get this PR merged?

jonnydford avatar Sep 12 '22 15:09 jonnydford

If everything looks good, please merge this PR asap. We use flask_oidc (1.4.0) with superset which breaks due to this.

tapanhalani avatar Sep 14 '22 13:09 tapanhalani

This project / repo needs a new owner.

khteh avatar Sep 14 '22 23:09 khteh

Any idea when this will be merged? @puiterwijk

rvhonorato avatar Oct 24 '22 08:10 rvhonorato

@ecederstrand sorry for my late response, I overlooked your merge request, but I have merged your changes now as well. Would be nice if this PR can now be merged into master

gerwout avatar Nov 02 '22 09:11 gerwout

@puiterwijk This needs a merge ASAP!

Panagiss avatar Nov 07 '22 15:11 Panagiss

@puiterwijk It would be awesome if you could merge this PR :)

Kalzau avatar Nov 07 '22 20:11 Kalzau

@puiterwijk Please can you merge this

benpocklingtonhes avatar Jan 24 '23 10:01 benpocklingtonhes

We should probably consider this repo unmaintained, fork it and fix it.

christian-hawk avatar Feb 03 '23 18:02 christian-hawk

@ramizarif @puiterwijk can we have this merged please?

zbhuiyan avatar Mar 01 '23 13:03 zbhuiyan

Any chance to see this MR merged?

gautierrog avatar Apr 11 '23 13:04 gautierrog

Still waiting…

frozenpandaman avatar Jul 31 '23 10:07 frozenpandaman