PUG-Bootstrap icon indicating copy to clipboard operation
PUG-Bootstrap copied to clipboard

[question] bootstrap 4?

Open joneldiablo opened this issue 7 years ago • 8 comments

this project is for pug and bootstrap 4 components?

joneldiablo avatar Mar 13 '18 19:03 joneldiablo

@joneldiablo Yes this is for pug but it is not yet updated to support Bootstrap 4

rajasegar avatar Mar 14 '18 04:03 rajasegar

So, when Bootstrap 4 ?

nsagot avatar Jul 11 '18 12:07 nsagot

To be honest @lyoko17220 I could not find time to work on it, but after looking at this thread i have made up my mind to kick start the project, will update you all asap once it is launched. 👍

rajasegar avatar Jul 11 '18 13:07 rajasegar

@rajasegar I would be interested in helping with the pug bs4 project.

zlix12 avatar Apr 13 '19 18:04 zlix12

I have the same "issue" here.

So it's 11/2020 and it still contains outdated Bootstrap. I tried to fix it myself, finding out that a lot of the stuff used in the snippets are already outdated, partly or fully. Sad for the hard work...

maybe a "rewrite from scratch" could be more successful instead of fixing the parts since a lot changed in BS4+

@rajasegar you wrote somewhere something about you need funding for it. What do we talk about? $100 $1000? :smile:

Also I'm wondering why you are using CDNs by Google. Which isn't always good too. Maybe using the Bootstrap CDN directly and also the JQuery CDN would be a bit better.

/E: Ok, I did a mistake... it takes a bit effort to rewrite it. But it seems possible.

I will do a push req, when I'm converted a lot of the stuff to the current Bootstrap.

ksaadDE avatar Nov 28 '20 02:11 ksaadDE

@ksaadDE Created a tracking issue for the same #32 All the changes are pushed on to the b4 branch https://github.com/rajasegar/PUG-Bootstrap/tree/b4 Will start working on this, but it will take some time, I cannot give a timeline, wish to complete it by this end of year, so hopefully we will have v4 support next year. And meanwhile I would also accept funding , this is my patreon page https://www.patreon.com/rajasegar

rajasegar avatar Dec 03 '20 04:12 rajasegar

@ksaadDE Created a tracking issue for the same #32 All the changes are pushed on to the b4 branch https://github.com/rajasegar/PUG-Bootstrap/tree/b4 Will start working on this, but it will take some time, I cannot give a timeline, wish to complete it by this end of year, so hopefully we will have v4 support next year. And meanwhile I would also accept funding , this is my patreon page https://www.patreon.com/rajasegar

Awesome, sounds great!

I tried to fix (at least) the navbar. The Rest seems to work, but we'll have to change the Navbar functionality. Take a look at my repo and you'll see the diff. Maybe you can change it to your preferred Style, so we will have the same functionality like before.

Just tell me how much you need over all for completing this project, I know that you have patreon, but that doesn't mean how much you're needing ;-) People are spending more when they know a) what for and b) how much is generally needed.

Currently I don't really have time to fix everything (or to write test / test it), but I think the navbar is the biggest Deal, since it's what people will mostly use and see.

Greetz

ksaadDE avatar Dec 03 '20 19:12 ksaadDE

and bs5? XD

joneldiablo avatar Jan 13 '21 16:01 joneldiablo