Daniel Puckowski

Results 61 comments of Daniel Puckowski

Looks like there are CI issues (may be resolved by https://github.com/less/less.js/pull/4322): ``` ╔═════════════════════════════════════════════════════════════════════════╗ ║ Looks like Playwright Test or Playwright was just installed or updated. ║ ║ Please run the...

> What change made it be treated like a function? https://github.com/less/less.js/pull/4237 The addition of ```declarationCall``` which must match functions before keywords (otherwise functions may be identified incorrectly as keywords) caused...

I pulled latest to get CI changes from https://github.com/less/less.js/pull/4333 and pushed again. CI is good now. I suspect any old PRs running into this issue will have to pull latest...

What do you think about merging this PR? I'd like to get this fix out the door soon to resolve the regression. Subsequent PRs can improve the solution. @matthew-dean

Ideally we merge https://github.com/less/less.js/pull/4344 before merging this release PR to resolve more issues in the short term. We can build upon #4344 at a later time if we decide we...

@matthew-dean Ideally we merge https://github.com/less/less.js/pull/4344 before merging this release PR to resolve more issues in the short term. We can build upon https://github.com/less/less.js/pull/4344 at a later time if we decide...

@matthew-dean I updated the release PR to include https://github.com/less/less.js/pull/4346 which was recently merged.

Release available on GitHub at https://github.com/less/less.js/releases/tag/v4.4.0 I tested ```lessc``` and the browser bundle off a fresh npm install and seems working as expected.

Looks like CI may have an issue. Tests pass locally for me. ``` browserType.launch: Executable doesn't exist at /home/runner/.cache/ms-playwright/chromium_headless_shell-1148/chrome-linux/headless_shell ╔═════════════════════════════════════════════════════════════════════════╗ ║ Looks like Playwright Test or Playwright was just installed...

I re-ran CI but ran into issues. Branch passes all tests locally for me. I wouldn't expect files changed to impact CI (two test files, one source file). Would you...