puck icon indicating copy to clipboard operation
puck copied to clipboard

feat: add move up and move down actions to DraggableComponent and Action Component Again.

Open OsamuBlack opened this issue 3 months ago • 6 comments

This PR is attempting to close #668.

  • Added "Move Up" and "Move Down" buttons to the DraggableComponent's action bar, with corresponding icons and logic to dispatch move actions and update UI selection. Actions are disabled when the item is at the boundary or drag is not permitted.
  • Checks permissions.drag before moving.
  • Uses MoveUp/MoveDown lucide-react icons
  • Disabled action state
  • Only use isLast to disable the onMoveDown

Known Issues:

  • onMoveUp does not rerender the selection.

OsamuBlack avatar Sep 16 '25 01:09 OsamuBlack

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
puck-demo Ready Ready Preview Comment Oct 6, 2025 9:43am
puck-docs Ready Ready Preview Oct 6, 2025 9:43am

vercel[bot] avatar Sep 16 '25 01:09 vercel[bot]

@OsamuBlack is attempting to deploy a commit to the Puck Team on Vercel.

A member of the Team first needs to authorize it.

vercel[bot] avatar Sep 16 '25 01:09 vercel[bot]

The issue tracking the move up overlay rendering problem is this one: #955

FedericoBonel avatar Oct 07 '25 06:10 FedericoBonel

Following this up with the last action we set up from the previous PR:

Hey @OsamuBlack sorry for the delay! I think this PR has the right bones, but still needs a bit of work from a UX point of view. It'll be easier for me to take it over the line at this point. Will finish it up soon.

This would also involve fixing the functional problems with the overlay not moving with the component (#955).

FedericoBonel avatar Oct 07 '25 09:10 FedericoBonel

Adding a request for changes so we can review this again and apply the necessary updates before merging, following up on the last comment from the previous PR.

Anything I need to check or change?

OsamuBlack avatar Oct 08 '25 06:10 OsamuBlack

Not on your end @OsamuBlack! Thanks again for the contribution, we just need to fix the overlay not moving bug and the UX

FedericoBonel avatar Oct 09 '25 02:10 FedericoBonel