Pi.Alert icon indicating copy to clipboard operation
Pi.Alert copied to clipboard

Update update_vendors.sh

Open dougie23fresh opened this issue 1 year ago • 6 comments

-LO will follow redirects

-L in case the page has moved (3xx response) curl will redirect the request to the new address -o output to a file instead of stdout (usually the screen). In your case the o flag is redundant since the output is piped to bash (for execution) - not to a file.

dougie23fresh avatar Mar 17 '23 21:03 dougie23fresh

upvoting...

andriymoroz avatar Apr 29 '23 17:04 andriymoroz

@andriymoroz

The main fork is pretty much dead, however, check out this comment: https://github.com/pucherot/Pi.Alert/issues/220#issuecomment-1467430701

jokob-sk avatar Apr 29 '23 21:04 jokob-sk

Upvoting. I just manually edited update_vendors.sh

only change was that each line now uses -LO.

sudo curl $1 -# -LO http://standards-oui.ieee.org/iab/iab.csv
 sudo curl $1 -# -LO http://standards-oui.ieee.org/iab/iab.txt

sudo curl $1 -# -LO http://standards-oui.ieee.org/oui28/mam.csv
 sudo curl $1 -# -LO http://standards-oui.ieee.org/oui28/mam.txt

sudo curl $1 -# -LO http://standards-oui.ieee.org/oui36/oui36.csv
 sudo curl $1 -# -LO http://standards-oui.ieee.org/oui36/oui36.txt

sudo curl $1 -# -LO http://standards-oui.ieee.org/oui/oui.csv
 sudo curl $1 -# -LO http://standards-oui.ieee.org/oui/oui.txt

herbiegreenfield avatar May 08 '23 18:05 herbiegreenfield

FYI the original report wasn't updated for 2 years. Check out the latest comment here https://github.com/pucherot/Pi.Alert/pull/221

jokob-sk avatar May 08 '23 21:05 jokob-sk

Thank you, yes this latest comment #221 gave me the info to modify BY ADDING “O” to flag -LO.

I landed into this from an old Reddit Post and subsequently installed, trouble shot, then uninstalled after seeing the forks. That led to a lot more troubleshooting too. :) for the server direct install on Raspberrian leiweibau fork which needed tweaks for python3 and for python libraries I was missing. Then log files are missing for php and the symlinks step fails too.

So far my install is running and I just need to prune down the hundred+ legacy devices imported from past years of PiHole. I suspect that dynamic IP addressing plays a part but I have a mess to untangle for PiAlert and PiHole to align logical common names to MAC addresses, and the moving IP addresses. Example: my smart Tv is labeled as a MacBook but vendor is Vizio. And there are a hundred+ untitled entries.

Thanks so much for the incredible improvements and contributions!!!

herbiegreenfield avatar May 09 '23 06:05 herbiegreenfield

I think we active maintainers only do this because we think the "tool" "pucherot/Pi.Alert" is great and that this software deserves to be maintained to stay great.

leiweibau avatar May 09 '23 08:05 leiweibau