Max Yang

Results 8 comments of Max Yang

#237 should take care of some of the low-hanging fruit. Beyond that, I did some profiling of the mesh in question on a Linux system with massif. First, it seems...

Looks like they deprecated the macos-10.15 container on gh actions? https://github.com/actions/virtual-environments/issues/5583

Some pictures: ![image](https://user-images.githubusercontent.com/21321692/114804985-0fef7900-9d57-11eb-8aab-c0a8cf55da97.png) ![image](https://user-images.githubusercontent.com/21321692/114805081-357c8280-9d57-11eb-9620-b2058758c472.png)

Thanks for writing this up @samuelpmishLLNL! Some comments: - `immintrin.h`: This does seem like a large independent contributor to compile times that would benefit from a compilation firewall. However, I...

I noticed that `ArrayView`'s constructor requires a non-const reference to `Array`, because `ArrayView` doesn't really protect the underlying data from being modified. As a workaround, I think we should consider...

The problem appears to be coming from Inlet, specifically this overload: https://github.com/LLNL/axom/blob/9d9ff2ba362086e8d699c4bb333d7b12930c6079/src/axom/inlet/Proxy.hpp#L79-L88 which seems to match with the implicitly-defined `operator[](std::ptrdiff_t, const char*)` on i386, apparently. I was able to replicate...

>Note: simply adding the AXOM_HOST_DEVICE annotation on these functions does not resolve the issue. Out of curiosity, is this because we aren't building with relocatable device code enabled (as mentioned...

> In the summary, can you briefly say if this this change lets us do something we couldn't do before? Or maybe whether it only streamlines, slimplify, whatever..., something we...