spectral-workbench icon indicating copy to clipboard operation
spectral-workbench copied to clipboard

Add mysql configs

Open icarito opened this issue 6 years ago • 3 comments

These are similar to the ones done in plots2

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • [ ] tests pass -- rake test
  • [ ] code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • [ ] pull request are descriptively named
  • [ ] if possible, multiple commits squashed if they're smaller changes
  • [ ] reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

icarito avatar May 08 '19 04:05 icarito

Awesome. Hi Sebastian! I also highlighted some queries in another recent issue to try to work on, hopefully in the next few days.

On Wed, May 8, 2019, 12:35 AM Sebastian Silva [email protected] wrote:

These are similar to the ones done in plots2

Make sure these boxes are checked before your pull request is ready to be reviewed and merged. Thanks!

  • tests pass -- rake test
  • code is in uniquely-named feature branch, and has been rebased on top of latest master (especially if you've been asked to make additional changes)
  • pull request are descriptively named
  • if possible, multiple commits squashed if they're smaller changes
  • reviewed/confirmed/tested by another contributor or maintainer

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/wiki/contributing-to-public-lab-software

Thanks!

You can view, comment on, or merge this pull request online at:

https://github.com/publiclab/spectral-workbench/pull/456 Commit Summary

  • Add mysql configs

File Changes

Patch Links:

  • https://github.com/publiclab/spectral-workbench/pull/456.patch
  • https://github.com/publiclab/spectral-workbench/pull/456.diff

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/spectral-workbench/pull/456, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J534E4MGFOYEHKYYZDPUJJ5JANCNFSM4HLOKA3A .

jywarren avatar May 08 '19 04:05 jywarren

Yes that's a good idea - we're getting small service interruptions due to load so it's good to fix this!

Also, this I've just deployed to production manually so we can merge this now if you agree!

icarito avatar May 08 '19 04:05 icarito

Yep!!!

On Wed, May 8, 2019, 12:50 AM Sebastian Silva [email protected] wrote:

Yes that's a good idea - we're getting small service interruptions due to load so it's good to fix this!

Also, this I've just deployed to production manually so we can merge this now if you agree!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/spectral-workbench/pull/456#issuecomment-490346092, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J3AHVSFBG5575E6FVDPUJLWXANCNFSM4HLOKA3A .

jywarren avatar May 08 '19 04:05 jywarren