spectral-workbench.js icon indicating copy to clipboard operation
spectral-workbench.js copied to clipboard

Remove extra search option

Open avsingh999 opened this issue 6 years ago • 8 comments

there are two search option ezgif com-video-to-gif

What happened before you saw the error

What you expected to happen

one search option should be remove

Browser, version, and operating system

firefox ubuntu 16.04 LTS (to help reproduce the issue)

For bug reports, fill out the above template; for feature requests, you can delete the template.

avsingh999 avatar Oct 17 '18 16:10 avsingh999

@jywarren @SidharthBansal @ebarry please look this issue and add label if this is valid thank you :)

avsingh999 avatar Oct 17 '18 17:10 avsingh999

Can you please send screenshot of the page we get after searching a particular text. I guess then there will be only a single search option. Thanks for ui suggestion.

SidharthBansal avatar Oct 19 '18 14:10 SidharthBansal

@SidharthBansal please look this, thanks

ss3

avsingh999 avatar Oct 22 '18 17:10 avsingh999

@jywarren which one should be removed?

SidharthBansal avatar Oct 22 '18 20:10 SidharthBansal

This task is published on GCI dashboard. Thanks all.

SidharthBansal avatar Oct 22 '18 20:10 SidharthBansal

Hmm, this is hard because the one in the header appears on /all/ pages, but only if you click it.

I guess the way to solve this would be to have it check if there is already a search input on the page. If there is not, it displays the extra one. If there is, it puts the cursor in the existing one.

How does that sound?

jywarren avatar Oct 22 '18 20:10 jywarren

Sounds great to me.

SidharthBansal avatar Oct 22 '18 20:10 SidharthBansal

where should the changes be made? i am GCI- candidate

prajwalkpatil avatar Nov 03 '18 14:11 prajwalkpatil