simple-data-grapher icon indicating copy to clipboard operation
simple-data-grapher copied to clipboard
verified publisher icon publiclab

fixes linting errors

Open ovpv opened this issue 6 years ago • 4 comments

Fixes #50

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] PR is descriptively titled 📑 and links the original issue above 🔗
  • [x] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [ ] screenshots/GIFs are attached 📎 in case of UI updation
  • [x] ask @publiclab/reviewers or the user who published the issue for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help!

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

ovpv avatar Oct 31 '19 06:10 ovpv

Hi @ovpv you have merge conflicts in your PR. check them out? rest LGTM

Hey @pythongiant , I have resolved the conflicts. Please check and let me know if there are any further issues.

ovpv avatar Dec 14 '19 03:12 ovpv

hey @pythongiant , After the latest pull from the main branch, The build checks are failing. I am not sure why that's happening? can you help?

ovpv avatar Dec 17 '19 04:12 ovpv

Looks like checks are passing now, Good work

pythongiant avatar Dec 22 '19 04:12 pythongiant

Looks like checks are passing now, Good work

hey @pythongiant , Does this usually take this much time to merge a PR in this repository or is it on hold due to some issue? if so please let me know.

ovpv avatar Jan 06 '20 07:01 ovpv