publiclab
Redesign Add Graph Button
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
Problem
The current Add Graph button is a simple bootstrap primary button.
📋Solution
<button type="button" class="btn btn-primary" id=' + this.addGraphButtonId + '> Add Graph</button>
Change the above line in
https://github.com/publiclab/simple-data-grapher/blob/fa222a480c402d15d260f70cb42c23694577e603/src/View.js#L347
By adding some styling, probably a fa fa-icon or some other color!
-
[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
-
[ ] 📝 Update
-
[ ] 💾 Commit your changes
-
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
-
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
-
You can also edit files directly in your browser and open a pull request from there.
- [ ] 🏁 Done Ask in comments for a review :)
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Go right ahead! Do let us know if you face any issues at all!
On Tue, Jul 23, 2019, 1:28 AM Vars [email protected] wrote:
first-timer here, I would like to fix this issue.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/69?email_source=notifications&email_token=AJXHQZYR4QYJJHQKY2HHPZLQAYGPLA5CNFSM4IFYN3HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD2Q7R3I#issuecomment-513931501, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ7YLMRDXELODQDKIT3QAYGPLANCNFSM4IFYN3HA .
I think he is, let's wait for him to respond!
On Fri, Jul 26, 2019, 10:23 AM Sreekanth Manda [email protected] wrote:
@VarsPhilos https://github.com/VarsPhilos are you still doing this? if not I would like to work.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/69?email_source=notifications&email_token=AJXHQZ6Q247O57MUVEEATPTQBJ7NNA5CNFSM4IFYN3HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD23PVSI#issuecomment-515308233, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ3VLJ3UAZYBEVXEJW3QBJ7NNANCNFSM4IFYN3HA .
Yes, would appreciate your help! Give it a shot!
On Fri, Oct 4, 2019, 1:57 PM S!$0 [email protected] wrote:
Is help still required?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/69?email_source=notifications&email_token=AJXHQZ3E2LAMYLRIOLQLZ4LQM347FA5CNFSM4IFYN3HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEAK5EHQ#issuecomment-538300958, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZZOXZNR6XJL2PM7NU3QM347FANCNFSM4IFYN3HA .
Feel free to brainstorm!
On Sat, Oct 19, 2019, 2:41 PM sivietz [email protected] wrote:
Hello, is this issue still open?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/69?email_source=notifications&email_token=AJXHQZZHK6BCJBDAGLEJVW3QPLFM7A5CNFSM4IFYN3HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEBXJNNY#issuecomment-544118455, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXHQZ3CKJDC6AMLHFH3NL3QPLFM7ANCNFSM4IFYN3HA .
Feel free to work on it?
On Thu, Oct 24, 2019, 8:38 PM Harry Kay [email protected] wrote:
hey is this issue still open? can i work on this?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/simple-data-grapher/issues/69?email_source=notifications&email_token=AJXHQZ72EG3DHKKGOOQWTC3QQG26VA5CNFSM4IFYN3HKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOECFL2GA#issuecomment-545963288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJXHQZZQNBRSINQG7CXNV5LQQG26VANCNFSM4IFYN3HA .
Yes @milbeeen , there is no active PR for this. So you can start working. Thanks
