plots2 icon indicating copy to clipboard operation
plots2 copied to clipboard

Change function t to translation in app/views/notes/_card.html.erb

Open jywarren opened this issue 4 years ago • 15 comments

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] 📝 Update the file app/views/notes/_card.html.erb in the plots2 repository (press the little pen Icon) and edit the line as shown below.

See this page for some help in taking your first steps!

Below is a "diff" showing in red (and a -) which lines to remove, and in green (and a +) which lines to add:

- 16: <%= t('notes._notes.moderate_first_time_post') %> <br class="d-none d-lg-inline"/>
+ 16: <%= translation('notes._notes.moderate_first_time_post') %> <br class="d-none d-lg-inline"/>

- 17: <a class="btn btn-outline-secondary btn-sm" href="/moderate/publish/<%= node.id %>"><%= t('notes._notes.approve') %></a>
+ 17: <a class="btn btn-outline-secondary btn-sm" href="/moderate/publish/<%= node.id %>"><%= translation('notes._notes.approve') %></a>

- 18: <a class="btn btn-outline-secondary btn-sm" data-test="spam" href="/moderate/spam/<%= node.id %>"><%= t('notes._notes.spam') %></a>
+ 18: <a class="btn btn-outline-secondary btn-sm" data-test="spam" href="/moderate/spam/<%= node.id %>"><%= translation('notes._notes.spam') %></a>

- 20: <%= raw t('notes._notes.pending_approval', :url1 => '/wiki/moderation') %>
+ 20: <%= raw translation('notes._notes.pending_approval', :url1 => '/wiki/moderation') %>

- 49: <li><a>Last Edited: <%= t('notes._notes.last_edit_by') %> <a <% if @widget %>target="_blank"<% end %> href="/profile/<%= node.latest.author.name %>"><%= node.latest.author.name %></a></a></li>
+ 49: <li><a>Last Edited: <%= translation('notes._notes.last_edit_by') %> <a <% if @widget %>target="_blank"<% end %> href="/profile/<%= node.latest.author.name %>"><%= node.latest.author.name %></a></a></li>

- 52: <li><a>Total Views: </i> <%= number_with_delimiter(node.views) %> <span class="d-none d-lg-inline"><%= t('notes._notes.views') %></span></a></li>
+ 52: <li><a>Total Views: </i> <%= number_with_delimiter(node.views) %> <span class="d-none d-lg-inline"><%= translation('notes._notes.views') %></span></a></li>

- 57: <li class="buttons mb-2"><% if @current_user && ['admin','moderator'].include?(@current_user.role) %><a style="width: 90px" class="btn btn-outline-secondary" href="/moderate/spam/<%= node.id %>"><i class="fa fa-ban"></i> <%= t('notes._notes.spam') %></a><% end %></li>
+ 57: <li class="buttons mb-2"><% if @current_user && ['admin','moderator'].include?(@current_user.role) %><a style="width: 90px" class="btn btn-outline-secondary" href="/moderate/spam/<%= node.id %>"><i class="fa fa-ban"></i> <%= translation('notes._notes.spam') %></a><% end %></li>

- 58: <li class="buttons"><a class="btn btn-outline-secondary" href="<%= node.path %>"><%= t('notes._notes.read_more') %></a></li>
+ 58: <li class="buttons"><a class="btn btn-outline-secondary" href="<%= node.path %>"><%= translation('notes._notes.read_more') %></a></li>

- 61: <a class="btn btn-outline-secondary" href="#"><i class="fa fa-ban-circle"></i> <%= t('notes._notes.spam') %></a>
+ 61: <a class="btn btn-outline-secondary" href="#"><i class="fa fa-ban-circle"></i> <%= translation('notes._notes.spam') %></a>
  • [ ] 💾 Commit your changes

  • [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] 🏁 Done Ask in comments for a review :)

Please keep us updated

💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!

If this happens to you, don't sweat it! Grab another open issue.

Is someone else already working on this?

🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.

👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

🤔❓ Questions?

Leave a comment below!

jywarren avatar Oct 09 '20 16:10 jywarren

Hi @swarajpure, are you still interested in working on this issue? I've moved it here -- thank you!

jywarren avatar Oct 09 '20 16:10 jywarren

@jywarren can i work on this, i am an outreachy applicant

GabriellaAmah avatar Oct 09 '20 16:10 GabriellaAmah

Hi @GabriellaAmah if @swarajpure does not respond in the next 24 hours, then that's fine, we'd love help! And to either of you, we're happy to open a new issue as well.

jywarren avatar Oct 09 '20 16:10 jywarren

Thank you both!

jywarren avatar Oct 09 '20 16:10 jywarren

I've just made a new issue in https://github.com/publiclab/plots2/issues/8510 for @GabriellaAmah if you'd like to claim that one - just say "i'd like to work on this and I'm with Outreachy" in there and you can go ahead!

jywarren avatar Oct 09 '20 16:10 jywarren

Is this still open?? I would like to work on this

crookshanks003 avatar Feb 03 '21 12:02 crookshanks003

Is this issue open? May I work on it?

Priyaraj17 avatar Mar 22 '21 09:03 Priyaraj17

Hi @Priyaraj17 - yes please go ahead! Or anyone else, please feel free to open a pull request, no need to ask permission, just leave a comment here and link us to your pull request! Thank you!!!

jywarren avatar Apr 09 '21 20:04 jywarren

Sorry, Earlier I made a mistake. This is the PR I have created.

Priyaraj17 avatar Apr 11 '21 11:04 Priyaraj17

Hello! First time contributor. I've submitted a pull request at the following link: #9737

jrogers-dev avatar Jun 05 '21 00:06 jrogers-dev

Hi, this one is open again! Thanks, everyone!

jywarren avatar Jul 13 '21 18:07 jywarren

@jywarren I want to work on this issue. Can I?

Onyinye91-ctrl avatar Aug 18 '21 19:08 Onyinye91-ctrl

@jywarren, I am a newbie here so I would love to start contributing to this repo with this issue. Can you please assign it to me?

Prerna-0202 avatar Nov 21 '21 08:11 Prerna-0202

@jywarren, Hi, Jeffery - I want to claim this issue. I, too, am a newbie - this will be my very first contribution(!!!) - and an Outreachy applicant... Would you please assign it to me?

stephaniequintana avatar Mar 18 '22 11:03 stephaniequintana

Removing the first-timers-only label until the issue is resolved.

TildaDares avatar Mar 23 '22 06:03 TildaDares