plots2 icon indicating copy to clipboard operation
plots2 copied to clipboard

Subscribing to already subscribed tag shows wrong alert

Open gautamig54 opened this issue 5 years ago ā€¢ 12 comments

When a user subscribe to the tag which already exists, the alert message says the "you are now following ###" instead it should say that "you have already subscribed to the tag".

Screen Shot 2019-04-20 at 5 12 14 PM

gautamig54 avatar Apr 20 '19 11:04 gautamig54

Hi, Is somebody working on it? I would like to contribute , I`m new in open source contributions šŸ‘ @gautamig54

valeriacobian avatar Apr 20 '19 17:04 valeriacobian

Go ahead @ValeriaCobianISW !!

namangupta01 avatar Apr 20 '19 17:04 namangupta01

@ValeriaCobianISW I am already working on this issue. I will ask for your help if need be. Thanks for checking in this.

gautamig54 avatar Apr 20 '19 18:04 gautamig54

@ValeriaCobianISW You can work on #5554 to begin with. Thanks!

gautamig54 avatar Apr 20 '19 18:04 gautamig54

Oh! if @gautamig54 is working on this. Here's is the list of fto https://github.com/publiclab/plots2/issues?q=is%3Aopen+is%3Aissue+label%3Afto-candidate. You can check this out.

namangupta01 avatar Apr 20 '19 18:04 namangupta01

Oh! Thanks, IĀ“m going to check that, thank you @gautamig54 @namangupta01 šŸ˜„

valeriacobian avatar Apr 20 '19 18:04 valeriacobian

@IshaGupta18 codebase for subscriptions page is not in the repo I think. How can I go about making this change?

gautamig54 avatar Apr 21 '19 09:04 gautamig54

Hey! Let me look into it and ill get back to you!

On Sun, Apr 21, 2019, 2:32 PM Gautami Gupta [email protected] wrote:

@IshaGupta18 https://github.com/IshaGupta18 codebase for subscriptions page is not in the repo I think. How can I go about making this change?

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/5556#issuecomment-485236473, or mute the thread https://github.com/notifications/unsubscribe-auth/AJXHQZ7LF3ROKRGO7O5VHP3PRQUTTANCNFSM4HHJQJUA .

IshaGupta18 avatar Apr 21 '19 17:04 IshaGupta18

@gautamig54 https://github.com/publiclab/plots2/blob/f8f136f20e890ea2ec9ac31ac9239388d38bdb00/app/views/home/subscriptions.html.erb there you go with the link to the file in the codebase!

IshaGupta18 avatar Apr 23 '19 14:04 IshaGupta18

I think this is the one, do correct me if I am wrong!

IshaGupta18 avatar Apr 23 '19 14:04 IshaGupta18

Please add a test too, if possible. Thanks!

grvsachdeva avatar Apr 30 '19 14:04 grvsachdeva

Is this issue open? If yes, I'd be glad to work on it. Thanks! @gautamig54 @IshaGupta18

KarishmaVanwari avatar Feb 23 '22 21:02 KarishmaVanwari