plots2 icon indicating copy to clipboard operation
plots2 copied to clipboard

Admin can ban itself

Open CleverFool77 opened this issue 5 years ago • 7 comments

Description

Hi @jywarren This is one of the unique issue that I found. While trying out the the revision history and the exploring button. I clicked on the ban button of revision history and as I was logged in as admin. And the button ban which I clicked was of the change done by me only. So when I clicked on the button, I got the message the instant is removed and user is banned, Thus I banned myself.

Screenshot 1 :

Screenshot from 2019-04-22 20-17-54

Screenshot 2 :

Screenshot from 2019-04-20 11-08-51

CleverFool77 avatar Apr 20 '19 06:04 CleverFool77

@publiclab/plots2-reviewers What's your opinion regarding this ? Thanks !!

CleverFool77 avatar Apr 20 '19 06:04 CleverFool77

IMHO I don't think an admin should be able to ban themselves. There might be cases where this is done accidentally.

siaw23-retired avatar Apr 22 '19 22:04 siaw23-retired

Agree with @siaw23!

grvsachdeva avatar Apr 22 '19 22:04 grvsachdeva

Hi @siaw23 @gauravano I tried on second image. And I did ban myself. Then I changed my status from db. I clicked on ban button and It removed my latest changes to wiki and banned myself showing the message the instant is removed and user is banned. Thanks !!

CleverFool77 avatar Apr 23 '19 03:04 CleverFool77

OK so this behaviour is not normal I think. Definitely a user shouldn't be able to ban themselves. As to what's done when a user is banned (with their changes) I think @jywarren can chime in on this one.

siaw23-retired avatar Apr 23 '19 04:04 siaw23-retired

Yes, I think so too @siaw23, let's wait for his suggestion on this one, then we can probably just add a condition to remove the ban option for the current user.

IshaGupta18 avatar Apr 24 '19 10:04 IshaGupta18

Please may I work on this issue ?

Forchapeatl avatar Mar 16 '22 15:03 Forchapeatl