plots2
plots2 copied to clipboard
publiclab
[Welcoming] Review & troubleshoot a newcomer's pull request
As part of our ongoing work to welcome newcomers, we need to help them make well-formatted pull requests, and troubleshoot the issues they encounter. This will help newcomers get started in a codebase they may not be familiar with! 🔍 🕵️
(see more issues like this here)
Find open pull requests
https://github.com/publiclab/plots2/pulls
See if they're a newcomer
Be encouraging!
Read their Travis errors
Leave inline comments
If you don't have access to review, then you can help us by writing reviews in comments Thanks
Hello, I've requested a review and made inline comments for this pull request: https://github.com/publiclab/plots2/pull/3557 . I believe the change would be all that would be needed to further debug the issue. I've submitted this task on GCI. Please let me know if there's anything else I should do.
i'll review it now! Thanks!!!
On Mon, Nov 26, 2018 at 5:55 PM Jonathan Xu [email protected] wrote:
Hello, I've requested a review and made inline comments for this pull request: #3557 https://github.com/publiclab/plots2/pull/3557 . I believe the change would be all that would be needed to further debug the issue. I've submitted this task on GCI. Please let me know if there's anything else I should do.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3458#issuecomment-441832110, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ2hGhiKJJxJqSW9gaa_nYt-zjeZxks5uzHFdgaJpZM4W4zTe .
Please delete it. This task is broken into weeks and repos before uploading it. Already done. Thanks
On Mon, 9 Dec 2019, 6:48 am Sasha Boginsky, [email protected] wrote:
** Uploaded to GCI dashboard**
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3458?email_source=notifications&email_token=AFAAEQ2T2R2F3T726JZ5W4LQXWMG7A5CNFSM4FXDGTPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGHQ7YI#issuecomment-563023841, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ4BHVZMRDOD6KLHYIDQXWMG7ANCNFSM4FXDGTPA .
This task is broken into weeks and repos before uploading it. Already done.
Sorry not sure I understand. You're saying a) it should be recreated separately for each repository. b) since we already 1 week into GCI, we should no longer upload it all anyway? Isn't this a supportive task for throughout the whole competition though?
Not sure I have the admin rights to delete it - but you'll find it on the dashboard under the same title as this issue @SidharthBansal
This is already broken by Keshav
On Mon, Dec 9, 2019 at 12:51 PM Sasha Boginsky [email protected] wrote:
This task is broken into weeks and repos before uploading it. Already done.
Sorry not sure I understand. You're saying a) it should be recreated separately for each repository. b) since we already 1 week into GCI, we should no longer upload it all anyway? Isn't this a supportive task for throughout the whole competition though?
Not sure I have the admin rights to delete it - but you'll find it on the dashboard under the same title as this issue @SidharthBansal https://github.com/SidharthBansal
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3458?email_source=notifications&email_token=AFAAEQ7IY7I2ZDAG2JRPE2LQXXWY5A5CNFSM4FXDGTPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIDOPI#issuecomment-563099453, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ3IMNVWY2SW4R57KB3QXXWY5ANCNFSM4FXDGTPA .
oh ok! So we need to add them for every week? So far I see week 1 @SidharthBansal
Yes, we need to create for every week. Week 1 is by Keshav. We are doing things in rotation. You can take week 5 if you want.
On Mon, Dec 9, 2019 at 1:22 PM Sasha Boginsky [email protected] wrote:
oh ok! So we need to add them for every week? So far I see week 1 @SidharthBansal https://github.com/SidharthBansal
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3458?email_source=notifications&email_token=AFAAEQ6HJFLA6UKRSHUO2QTQXX2MTA5CNFSM4FXDGTPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGIF62Y#issuecomment-563109739, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQYF5AUJLW3SHX73VYLQXX2MTANCNFSM4FXDGTPA .
@SidharthBansal ok sure. wouldnt it be easier to just upload them all now and then you publish them as the week comes along?
Yes it is. I think @ishaGupta18 @ananyaarun are busy these days. I asked them to upload for some weeks. You can upload for week 2 if you want. K tasks for k repos. Just copy and paste thing. So it will take 10 min. Thanks
On Mon, 9 Dec 2019, 2:54 pm Sasha Boginsky, [email protected] wrote:
@SidharthBansal https://github.com/SidharthBansal ok sure. wouldnt it be easier to just upload them all now and then you publish them as the week comes along?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/issues/3458?email_source=notifications&email_token=AFAAEQ3VZKWA7QZ7575JOETQXYFFNA5CNFSM4FXDGTPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGINWOI#issuecomment-563141433, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ7QRDPLUOYSL27TINDQXYFFNANCNFSM4FXDGTPA .
