plots2
plots2 copied to clipboard
Resolves #4076 : remove drupal file and drupal upload
Fixes https://github.com/publiclab/plots2/issues/4076
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [x] PR is descriptively titled 📑 and links the original issue above 🔗
- [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
rake test
- [x] code is in uniquely-named feature branch and has no merge conflicts 📁
- [x] screenshots/GIFs are attached 📎 in case of UI updation
- [ ] ask
@publiclab/reviewers
for help, in a comment below
Purpose
- Remove
drupal_file
model - Remove
drupal_upload
model - Remove association from
drupal_main_image
model - Update
.rubocop_todo.yml
to not include removed models - Remove association from
node
model - Drop
files
table - Drop
upload
table - Update
db/schema.rb.example
to not haveupload
andfiles
tables
Code Climate has analyzed commit 4e1f8d65 and detected 0 issues on this pull request.
View more on Code Climate.
@jywarren @TildaDares - When I remove upload
and files
tables, the build is failing. Do you have any idea why this might be happening?
Hi! So the tests are probably failing because there are dependencies in the test files. Try running the test suite, and see what errors are logged.
For more detailed analysis, you can run every test file and see what the failures are. If you need any help, feel free to send a message here, pinging me.
Hi :smile:, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress
label :tada: . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! :100: Thank you for your contributions! :raised_hands: :balloon:.