plots2
plots2 copied to clipboard
Migrate DrupalFile content to Revision of node
Fixes #4076
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [ ] PR is descriptively titled 📑 and links the original issue above 🔗
- [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
rake test
- [ ] code is in uniquely-named feature branch and has no merge conflicts 📁
- [ ] screenshots/GIFs are attached 📎 in case of UI updation
- [ ] ask
@publiclab/reviewers
for help, in a comment below
Ref: #11185
Code Climate has analyzed commit bf757151 and detected 0 issues on this pull request.
View more on Code Climate.
This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8124761841/artifacts/351833681
For this issue as well, should I keep the migration and deletion of tables as different MRs?
Yes please!
Yes I believe so I think it's better to confirm it's working before we do a destructive database action. Thanks!
On Sun, Sep 4, 2022, 3:10 AM Anirudh Prabhakaran @.***> wrote:
For this issue as well, should I keep the migration and deletion of tables as different MRs?
— Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/pull/11387#issuecomment-1236275703, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J46BWJINAFLLNDGEQLV4RDPXANCNFSM6AAAAAAQEGJK3I . You are receiving this because your review was requested.Message ID: @.***>
Hi :smile:, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress
label :tada: . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! :100: Thank you for your contributions! :raised_hands: :balloon:.