plots2 icon indicating copy to clipboard operation
plots2 copied to clipboard

Migrate DrupalFile content to Revision of node

Open anirudhprabhakaran3 opened this issue 2 years ago • 7 comments

Fixes #4076

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ ] PR is descriptively titled 📑 and links the original issue above 🔗
  • [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [ ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [ ] screenshots/GIFs are attached 📎 in case of UI updation
  • [ ] ask @publiclab/reviewers for help, in a comment below

Ref: #11185

anirudhprabhakaran3 avatar Sep 04 '22 06:09 anirudhprabhakaran3

gitpod-io[bot] avatar Sep 04 '22 06:09 gitpod-io[bot]

Code Climate has analyzed commit bf757151 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Sep 04 '22 06:09 codeclimate[bot]

This pull request generated screenshots of many common pages in the running app. You should be able to download and view them here: https://github.com/publiclab/plots2/suites/8124761841/artifacts/351833681

github-actions[bot] avatar Sep 04 '22 06:09 github-actions[bot]

For this issue as well, should I keep the migration and deletion of tables as different MRs?

anirudhprabhakaran3 avatar Sep 04 '22 07:09 anirudhprabhakaran3

Yes please!

jywarren avatar Sep 05 '22 17:09 jywarren

Yes I believe so I think it's better to confirm it's working before we do a destructive database action. Thanks!

On Sun, Sep 4, 2022, 3:10 AM Anirudh Prabhakaran @.***> wrote:

For this issue as well, should I keep the migration and deletion of tables as different MRs?

— Reply to this email directly, view it on GitHub https://github.com/publiclab/plots2/pull/11387#issuecomment-1236275703, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAAF6J46BWJINAFLLNDGEQLV4RDPXANCNFSM6AAAAAAQEGJK3I . You are receiving this because your review was requested.Message ID: @.***>

jywarren avatar Oct 11 '22 08:10 jywarren

Hi :smile:, this issue has been automatically marked as stale because it has not had recent activity. Don't worry you can continue to work on this and ask @publiclab/reviewers to add in-progress label :tada: . Otherwise, it will be closed if no further activity occurs in 10 days -- but you can always re-open it if you like! :100: Thank you for your contributions! :raised_hands: :balloon:.

stale[bot] avatar Oct 15 '23 12:10 stale[bot]