plots2
plots2 copied to clipboard
publiclab
Subheadings within a page are hidden under fixed banner when internal links are used
When a subsection link is clicked, the heading of the subsection is hidden behind the fixed header. Example below:
https://user-images.githubusercontent.com/63427719/156079164-5be4fe47-d40c-43e0-aa98-6e75260638c5.mov
This can be corrected with CSS.
Original comment by @ebarry
Quick question as to whether there's an issue filed for how clicking a link to a subsection of a page causes the page to load with the heading underneath the navbar and under the banner if there's presently a banner up? It's disorienting to navigate to subheadings and arrive at what appears to be an unlabeled block of text for instance explore the links in : https://publiclab.org/wiki/contributing-to-reviews
Just noting these two old issues that may be helpful context! #2512 #1568
I think one way we tried to solve this was to add -100 top positioning to each heading:
https://github.com/publiclab/plots2/pull/2512/files#diff-463e60e626241c46963af84593cec984ba6276eefa33d87e1c866706351ede41R65-R70
We also tried adding margin or padding to the floating navbar, i think, as that's what's causing the offset to be incorrect!
Hi everyone. Under the assumption of @Ash-KODES being preoccupied with other important matters, Please may I work on this issue?
Hi everyone. Under the assumption of @Ash-KODES being preoccupied with other important matters, Please may I work on this issue?
Sorry,got busy with university exams.. will be making a PR in next 12 hours,if not done then you can definetly work on the issue.
Hi everyone. Under the assumption of @Ash-KODES being preoccupied with other important matters, Please may I work on this issue?
Sorry,got busy with university exams.. will be making a PR in next 12 hours,if not done then you can definetly work on the issue.
Okay , I don't mind you fixing the issue ,please take your time. I just thought you forgot . I'm sorry.
Hello @TildaDares @jywarren, this issue is still open, but @Ash-KODES already worked on it here, the merge was blocked for some reason. I'd like to work on it if it is available
Hello all, we appreciate the help! How are you thinking of approaching this? Have you looked at https://github.com/publiclab/plots2/pull/10782 to see how that went? Thanks!
Hello all, we appreciate the help! How are you thinking of approaching this? Have you looked at #10782 to see how that went? Thanks!
Hello @jywarren i've seen there is a PR by @Ash-KODES and @7malikk on the issue #10782
