plots2
plots2 copied to clipboard
publiclab
Map floats over footer while scrolling! - UI Bug (1/3)
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
📋 Step by Step
- [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
See this page for some help in taking your first steps!
Todo:
- [ ] 📝 Update: On this file https://github.com/publiclab/plots2/blob/main/app/assets/stylesheets/map.css add this block of code
.leaflet-pane{
position: initial !important;
}
.leaflet-bar, .leaflet-top{
position: initial !important;
}
This solution was worked on by @wajeehamushtaq on #10358
-
[ ] 💾 Commit your changes
-
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
-
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
-
You can also edit files directly in your browser and open a pull request from there.
- [ ] 🏁 Done Ask in comments for a review :)
Please keep us updated
💬⏰ - We encourage contributors to be respectful to the community and provide an update within a week of claiming a first-timers-only issue. We're happy to keep it assigned to you as long as you need if you update us with a request for more time or help, but if we don't see any activity a week after you claim it we may reassign it to give someone else a chance. Thank you in advance!
If this happens to you, don't sweat it! Grab another open issue.
Is someone else already working on this?
🔗- We encourage contributors to link to the original issue in their pull request so all users can easily see if someone's already started on it.
👥- If someone seems stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
🤔❓ Questions?
Leave a comment below!
Original information about the issue
look here -> https://publiclab.org/post
@Jon-Jos , I have checked this, but at my side it is completely fine. The map did not float over the footer section. Can you please further explain at which event this will happen?
Then
Hi @Jon-Jos thanks for helping to find this bug - and for continuing to document it - if it's possible to show a video of how to reproduce it that'd be great -- or @wajeehamushtaq were you able to see it happen too?
I do want to note that our "first-timers-only" issues have a very specific format which include the specific changes to be made. So this is more like a "fto-candidate" -- which might be converted into a full "first-timers-only" once a solution is included, if it's simple enough and easy to confirm when completed! I'll adjust the labeling accordingly. Thanks a lot!!!
This has been marked as a good candidate for becoming a first-timers-only issue like these, meaning that it's simple, self-contained, and with some extra formatting, could be a great entry point for a new contributor. If you're familiar enough with this code, please consider reformatting or reposting it as a first-timers-only issue, and then ping @publiclab/reviewers to get it labelled. Or, if this is not your first time, try to solve it yourself!
Hi @jywarren , Thank you for guiding us. I tried a solution, the problem arise due to leaflet map styling. The position is set to absolute so this will create the problem. I have created a pull request by fixing this issue. https://github.com/publiclab/plots2/pull/10327
I can report that in publiclab.org/post , after clicking "add a location" button, the map that appears does float over the footer. So the original issue is still happening, if that matters for prioritizing review of the associated PR.
Hi @itsgurmannatsohal, this is still happening, the changes mentioned above may not solve it, but we would like your help if you would like to give it a try. thanks
Hey! is this issue still open? If yes, I would like to work on this. Please assign.
@lata-11 seems @itsgurmannatsohal may be working on this, if they are not, you could propose a solution
if that's fine by @cesswairimu
@7malikk I'm working on this but I'm facing issues with the set up. The localhost throws internal server error 500 on running the server and various warnings get logged. No error is shown that I could look into just a 500 status code. Could you please help?
@7malikk I'm working on this but I'm facing issues with the set up. The localhost throws internal server error 500 on running the server and various warnings get logged. No error is shown that I could look into just a 500 status code. Could you please help?
Hello @itsgurmannatsohal have you tried the suggestions @TildaDares brought up in the community chat? Here it is: "Hi Gurmannat, have you tried stopping and restarting the server? If that doesn’t work, please paste a link to the stack trace from your console or post a screenshot of the issue. Thank you!"
