mapknitter icon indicating copy to clipboard operation
mapknitter copied to clipboard

map editing permissions initial

Open ViditChitkara opened this issue 5 years ago • 3 comments

closes #893

ViditChitkara avatar Aug 13 '19 20:08 ViditChitkara

Code Climate has analyzed commit 78980d75 and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1
Style 2

View more on Code Climate.

codeclimate[bot] avatar Aug 13 '19 20:08 codeclimate[bot]

@jywarren I'm starting with this. We still need some more details on how to put the toggle permission button on the map sidebar. @sashadev-sky shared some cool ideas #893 . If you could have a look at this and the issue as well! Thanks.

ViditChitkara avatar Aug 13 '19 20:08 ViditChitkara

Codecov Report

Merging #937 into main will decrease coverage by 4.41%. The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   72.71%   68.29%   -4.42%     
==========================================
  Files          35       35              
  Lines        1356     1369      +13     
==========================================
- Hits          986      935      -51     
- Misses        370      434      +64
Impacted Files Coverage Δ
app/controllers/maps_controller.rb 85.12% <18.18%> (-6.77%) :arrow_down:
app/models/map.rb 56.66% <33.33%> (-36.54%) :arrow_down:

codecov[bot] avatar Aug 13 '19 20:08 codecov[bot]