mapknitter icon indicating copy to clipboard operation
mapknitter copied to clipboard

Map-bars not displayed in a single line

Open divyabaid16 opened this issue 5 years ago • 6 comments

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • [] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] 📝 Update In /about Map-bar is not displayed on a single line. Its right end of the scale is carried forward to the bottom line. i.e cm/px is displayed on the next line. So as to remove it, decrease the width of the Map-bar. To do this, In change 100 to 160 https://github.com/publiclab/mapknitter/blob/3ca0b08749d31d9f354518ae29ece4690a1248ca/app/views/maps/_statistics.html.erb#L23

Selection_218

  • [ ] 💾 Commit your changes

  • [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

divyabaid16 avatar Aug 01 '19 18:08 divyabaid16

Hi, can I work on this?

catehernandez avatar Aug 02 '19 14:08 catehernandez

Yes go on. And don't hesitate to ask if stuck. Thanks!

divyabaid16 avatar Aug 02 '19 15:08 divyabaid16

Hi! ARGH I have been stuck on the pull request. Something about unmerged files. What happened? Screen Shot 2019-08-09 at 11 10 13 AM

catehernandez avatar Aug 09 '19 15:08 catehernandez

Hi @zenon21 , I guess you haven't synced with the upstream branch. Hence, merge conflicts are arising. Please read this and try to sync with upstream then commit the changes and open a PR. Sorry for the late response though.

divyabaid16 avatar Aug 27 '19 07:08 divyabaid16

Hi, My Outreachy 2022 application is approved. Can I work on this issue?

pranayrauni avatar Apr 06 '22 10:04 pranayrauni

Hi @17sushmita , I am an outreachy applicant, can I work on this issue?

shubhi-arora avatar Apr 15 '22 14:04 shubhi-arora