mapknitter icon indicating copy to clipboard operation
mapknitter copied to clipboard

Consistent hover style on hovering on image menu

Open igniteeng000 opened this issue 5 years ago • 20 comments

Description

We would like to standardize all the tooltips in this page to Bootstrap style tooltips?

https://getbootstrap.com/docs/4.3/components/

Show me where to look

While logged-in, when you hover on a map e.g https://mapknitter.org/maps/lamba1 you can see the tooltips on hover

confirm

Lets choose one style and standardize it for all the tooltips here.


We are participating in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more

igniteeng000 avatar Apr 02 '19 23:04 igniteeng000

We can surely improve here. Thanks @igniteeng000!

grvsachdeva avatar Apr 14 '19 10:04 grvsachdeva

We are participating in Google Code-in, and have reserved this issue for participants in GCI - but we'd love to have your help with another one! Please check out https://code.publiclab.org to see more

cesswairimu avatar Dec 01 '19 10:12 cesswairimu

Can someone please update this issue using FTO template? @ananyaarun @cesswairimu @debck @keshav234156 @pydevsg all the beginner issues should be in fto template. Thanks

SidharthBansal avatar Dec 06 '19 08:12 SidharthBansal

Updated this to a medium also updated on the gci dashboard...will add more context...Thanks

cesswairimu avatar Dec 06 '19 15:12 cesswairimu

Once you are done. Please ping me so that I can publish. Don't forget to add reserved for GCI header, code links and hide stale comments

SidharthBansal avatar Dec 06 '19 16:12 SidharthBansal

Happy coding :-)

SidharthBansal avatar Dec 06 '19 16:12 SidharthBansal

@SidharthBansal, I was just confirming this locally and seems like all the tooltips changed to a black background...what do u think should we close this or do we change all of them :thinking:

confirm

cesswairimu avatar Dec 06 '19 16:12 cesswairimu

Let's ping @jywarren.

On Fri, Dec 6, 2019 at 10:19 PM Cess [email protected] wrote:

@SidharthBansal https://github.com/SidharthBansal, I was just confirming this locally and seems like all the tooltips changed to a black background...what do u think should we close this or do we change all of them 🤔 [image: confirm] https://user-images.githubusercontent.com/17081074/70340200-5f6b8e00-1861-11ea-90fa-93a6a26c3eff.gif

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/475?email_source=notifications&email_token=AFAAEQ5HHV2VNMHDSW5XN4DQXJ7AHA5CNFSM4HDFFSR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEGEVWCI#issuecomment-562649865, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ2SAANIBJ3NLPWIX6LQXJ7AHANCNFSM4HDFFSRQ .

SidharthBansal avatar Dec 06 '19 17:12 SidharthBansal

Hi all!!! Thanks!

Do we think we could standardize to Bootstrap style tooltips?

https://getbootstrap.com/docs/4.3/components/

jywarren avatar Dec 09 '19 22:12 jywarren

Sweet! I will update the description. Thanks

cesswairimu avatar Dec 10 '19 05:12 cesswairimu

Published on gci dashboard

SidharthBansal avatar Dec 18 '19 10:12 SidharthBansal

sorry forgot to update the issue updating..now

cesswairimu avatar Dec 18 '19 17:12 cesswairimu

Done...Thanks @SidharthBansal

cesswairimu avatar Dec 18 '19 17:12 cesswairimu

Hi can i work on this?

pythongiant avatar Jan 02 '20 06:01 pythongiant

@SidharthBansal could you guide me which file to check it out?

pythongiant avatar Jan 02 '20 06:01 pythongiant

Hi @pythongiant here is the piece of code that has those icons https://github.com/publiclab/mapknitter/blob/main/app/views/images/_index.html.erb#L76-L91

cesswairimu avatar Jan 02 '20 09:01 cesswairimu

Thanks Cess

On Thu, Jan 2, 2020 at 2:57 PM Cess [email protected] wrote:

Hi @pythongiant https://github.com/pythongiant here is the piece of code that has those icons https://github.com/publiclab/mapknitter/blob/main/app/views/images/_index.html.erb#L76-L91

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/475?email_source=notifications&email_token=AFAAEQ7IIKRFRCSAJLNLXPDQ3WXRBA5CNFSM4HDFFSR2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEH5543Y#issuecomment-570154607, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFAAEQ4QZ3S52CILZF2DTWDQ3WXRBANCNFSM4HDFFSRQ .

SidharthBansal avatar Jan 02 '20 16:01 SidharthBansal

https://www.w3schools.com/bootstrap/tryit.asp?filename=trybs_tooltip&stacked=h @igniteeng000 @jywarren @SidharthBansal i am thinking of using this. Is it the correct method?

pythongiant avatar Jan 03 '20 07:01 pythongiant

@pythongiant, Jeff suggested we standardize to Bootstrap style tooltips. You could choose one of the style here and have it consistent for all the tooltips on the image menu. https://getbootstrap.com/docs/4.3/components/tooltips/ Sorry for the late reply.

cesswairimu avatar Jan 07 '20 18:01 cesswairimu