mapknitter
mapknitter copied to clipboard
publiclab
Allowing upload of images only
Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.
If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!
We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝
If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!
🤔 What you will need to know.
Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.
Problem
Multiple types of file can be uploaded in the upload image section.
📋Solution
Change this line:
https://github.com/publiclab/mapknitter/blob/de156283193542b10607542db5544ae400cf48bc/app/views/images/_new.html.erb#L19
To:
<i class="fa fa-plus-circle"></i> Select images <input id="warpable_uploaded_data" name="warpable[uploaded_data]" type="file" accept="image/*" />
-
[ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!
-
[ ] 📝 Update
-
[ ] 💾 Commit your changes
-
[ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:
-
If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.
-
You can also edit files directly in your browser and open a pull request from there.
- [ ] 🏁 Done Ask in comments for a review :)
🤔❓ Questions?
Leave a comment below!
Is someone else already working on this?
We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!
Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!
![welcome[bot] avatar](https://avatars.githubusercontent.com/in/4141?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @marieram, you can claim this one. You can see #329 for more details and ask @IshaGupta18 or me for any help. Thanks!
Yes! Go right ahead and don't hesitate to ask for any help! Thanks a lot!
On Tue, Feb 12, 2019, 12:21 AM Gaurav Sachdeva <[email protected] wrote:
Hi @marieram https://github.com/marieram, you can claim this one. You can see #329 https://github.com/publiclab/mapknitter/issues/329 for more details and ask @IshaGupta18 https://github.com/IshaGupta18 or me for any help. Thanks!
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/338#issuecomment-462447656, or mute the thread https://github.com/notifications/unsubscribe-auth/Am54Z5SNCjYf10YnOYRQdHVmYPFDVYwJks5vMbukgaJpZM4a0wu4 .
Hi @marieram, you can claim this one. You can see #329 for more details and ask @IshaGupta18 or me for any help. Thanks!
do you mean me? because you tagged someone else. thanks anyway :)
What a timing :sweat_smile:. you can surely claim this one @Jordenng. Thanks!
@IshaGupta18 I am looking for two FTOs for @marieram and @ctam853, they are also looking for a issue to take a dig, so please tag them if you see any such opportunity. Thanks!
Hi @panhabot, this issue is claimed by @Jordenng. But, we would love to have your help, you can find more issues at https://code.publiclab.org/#r=all and let us know by commenting below if you can't find any. Thanks!
@panhabot I just created some FTO's at https://github.com/publiclab/plots2/. If you are still looking for issues to work on, then claim this one - https://github.com/publiclab/plots2/issues/4821. Thanks!
@Jordenng how's the work going on this one? Just checking in to see if you need any help!
@gauravano sorry I replied a bit late. I think someone has already claimed it. Thank!
No issue @panhabot. I will mention you again if I see/create a FTO candidate. Thanks!
@meet2410shah this issue has already been claimed by @Jordenng. If he isn't working on this, then you can take this up.
Yeah, but let's wait for @Jordenng . @Jordenng are you still working on this one?
Okay! Please can you suggest another issue which is currently not claimed by anyone?
Yes:)
On Wednesday, February 20, 2019, Meet Shah [email protected] wrote:
Okay! Please can you suggest another issue which is currently not claimed by anyone?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/338#issuecomment-465700307, or mute the thread https://github.com/notifications/unsubscribe-auth/AePNdYq_fzOwQ90p8z78ZQJbryN2q7ZSks5vPZTigaJpZM4a0wu4 .
-- Yarden
I am working on it
On Thursday, February 21, 2019, Yarden Nagel [email protected] wrote:
Yes:)
On Wednesday, February 20, 2019, Meet Shah [email protected] wrote:
Okay! Please can you suggest another issue which is currently not claimed by anyone?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/mapknitter/issues/338#issuecomment-465700307, or mute the thread https://github.com/notifications/unsubscribe-auth/AePNdYq_fzOwQ90p8z78ZQJbryN2q7ZSks5vPZTigaJpZM4a0wu4 .
-- Yarden
-- Yarden
Okay, so I saw that you made a Pull request in your own local repository. You are supposed to make a PR here, in this repository. Does this make sense?
Hey @Jordenng, please add Fixes #338 in your PR's main comment to tag this issue, it will help other users to refer your PR easily and also closes this issue automatically when your PR gets merged(due to Fixes keyword).
Thanks!
I am afraid, not @Jordenng, could you please look up on how to make a PR in the main repo? We need a PR in this repo for it to be merged.
