mapknitter icon indicating copy to clipboard operation
mapknitter copied to clipboard

The coordinates lat & lon doesn't match the location on pin info window

Open illyShelly opened this issue 3 years ago β€’ 6 comments

What happened just before the problem occurred

I opened up mapknitter website and explored the map πŸ—ΊοΈ of Nairobi city in Kenya πŸ‡°πŸ‡ͺ . When clicked on the pin/marker πŸ“Œ it shows picture with title, location, lat and longitude.

Problem/suggestion when you check the printscreen below the location doesn't correspond to the lat and lon - show Paris instead of Nairobi.

Would not be nice to have some check whether location actually belongs to the coordinates? πŸ˜‰

Screenshot 2022-04-28 at 21 03 03

Relevant URLs

https://mapknitter.org/#13/-1.2362/36.8301/

PublicLab.org username

(to help reproduce the issue)

Browser, version, and operating system

Mac OS, Safari, Chrome

For bug reports, fill out the above template; for feature requests, you can delete the template.

illyShelly avatar Apr 28 '22 19:04 illyShelly

Hi @cesswairimu,@jywarren can you please look at it.

illyShelly avatar May 04 '22 18:05 illyShelly

Hi @illyShelly, really great catch :tada: I was able to see the same on the website. I will look more into this, we would love your help too if your interested. thanks for opening this

cesswairimu avatar May 10 '22 10:05 cesswairimu

@cesswairimu Hi πŸ™‚ I would love to! I tried to go through code base, but I am not familiar with it so I didn't know which file to test.

illyShelly avatar May 10 '22 10:05 illyShelly

This is the file https://github.com/publiclab/mapknitter/blob/main/app/views/front_ui/index.html.erb. I will add any info I find here too. thanks

cesswairimu avatar May 10 '22 11:05 cesswairimu

@cesswairimu hi, I just wonder. Last approx. 1 week I cannot see live on the website and when running locally the pins (location). Nor in Safari, nor in Chrome. I checked my settings, cookies and everything looks okay??

Not sure, why do I have this problem. btw. the location is wrong (some leaflet-pane) - I guess, it's was probably set by user. Or am I wrong? The places, which are hardcoded with lat, and Lon are alright. I wanted to check as well how it is with pins, but without working those πŸ™ƒ Any idea?

illyShelly avatar May 12 '22 20:05 illyShelly

@cesswairimu, I guess I got it. I thought there is bug in the code. But because the map was created by @anonymous, and the map itself is called 'nowhere' which captures Nairobi with location (created piece of screenshot) from Paris (France). It's ended up with quite wrong popup window with misleading informations.

Probably we cannot influence what piece of picture (mapshot) any user put together. We can just change it here - I guess it was made by someone 7 years ago, who actually was working on the mapknitter app πŸ™‚

I still like to know which file puts together that popup window - I found the separate one solving images on aws s3, but where it grabs that title, author etc. I know it uses some library but still I want to know more :)

This is under map nowhere from @anonymous with location in Paris: Screenshot 2022-05-14 at 17 19 43

So, then it looks like as above picture on the Nairobi hardcoded coordinates:

Screenshot 2022-05-14 at 17 25 12

illyShelly avatar May 14 '22 15:05 illyShelly