leaflet-environmental-layers icon indicating copy to clipboard operation
leaflet-environmental-layers copied to clipboard

added modal to the infomartion display

Open neelesh17 opened this issue 4 years ago • 6 comments

Fixes #444 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] PR is descriptively titled 📑 and links the original issue above 🔗
  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
  • [x] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [x] screenshots/GIFs are attached 📎 in case of UI updation
  • [x] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

neelesh17 avatar Mar 18 '20 09:03 neelesh17

yes @crisner it is working locally on my device. 123

neelesh17 avatar Mar 20 '20 06:03 neelesh17

Awesome! Thanks! Could you fix the conflicting files?

crisner avatar Mar 20 '20 06:03 crisner

@crisner I made the changes you requested.

neelesh17 avatar Mar 21 '20 14:03 neelesh17

     TypeError: undefined is not a constructor (evaluating 'new L.Control.GPlaceAutocomplete') in file:///home/travis/build/publiclab/leaflet-environmental-layers/dist/LeafletEnvironmentalLayers_babel.js (line 5139) (1)

Hmm, what could be causing this error? https://travis-ci.com/github/publiclab/leaflet-environmental-layers/builds/158924297#L301

jywarren avatar Apr 14 '20 20:04 jywarren

Hopefully this error is fixed by https://github.com/publiclab/leaflet-environmental-layers/pull/454 ?

nstjean avatar Apr 29 '20 17:04 nstjean

Indeed, could you try rebasing and rebuilding it? Thanks!

there are more tips and guides on rebasing here: https://publiclab.org/wiki/developers#Resources

jywarren avatar May 07 '20 22:05 jywarren