leaflet-environmental-layers
leaflet-environmental-layers copied to clipboard
added modal to the infomartion display
Fixes #444 (<=== Add issue number here)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [x] PR is descriptively titled 📑 and links the original issue above 🔗
- [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR
- [x] code is in uniquely-named feature branch and has no merge conflicts 📁
- [x] screenshots/GIFs are attached 📎 in case of UI updation
- [x] ask
@publiclab/reviewers
for help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X
to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
Thanks!
yes @crisner it is working locally on my device.
Awesome! Thanks! Could you fix the conflicting files?
@crisner I made the changes you requested.
TypeError: undefined is not a constructor (evaluating 'new L.Control.GPlaceAutocomplete') in file:///home/travis/build/publiclab/leaflet-environmental-layers/dist/LeafletEnvironmentalLayers_babel.js (line 5139) (1)
Hmm, what could be causing this error? https://travis-ci.com/github/publiclab/leaflet-environmental-layers/builds/158924297#L301
Hopefully this error is fixed by https://github.com/publiclab/leaflet-environmental-layers/pull/454 ?
Indeed, could you try rebasing and rebuilding it? Thanks!
there are more tips and guides on rebasing here: https://publiclab.org/wiki/developers#Resources