infragram icon indicating copy to clipboard operation
infragram copied to clipboard

Published 20 hours ago • verified publisher icon publiclab

Issues in webglColormapGenerator.js file

Open Somya-Singhal opened this issue 2 years ago • 4 comments

pl-6

I found there are some bugs in this file like fn function is declared inside if statement but used outside it also and some issues with opening and closing of paranthesis.

Somya-Singhal avatar Apr 03 '22 05:04 Somya-Singhal

Hello @TildaDares , Can I work on this issue to improve the code?

Somya-Singhal avatar Apr 03 '22 05:04 Somya-Singhal

Hi @Somya-Singhal sure, if you'd like to open a PR that would be great! Thank you!

jywarren avatar Apr 05 '22 20:04 jywarren

Sure, I will do it shortly.

Somya-Singhal avatar Apr 06 '22 00:04 Somya-Singhal

Hello @jywarren , I linked a pull request. Can you please review it and suggest the changes if any needed?

Somya-Singhal avatar Apr 06 '22 18:04 Somya-Singhal