image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

[suggestion] Add Dark theme

Open avsingh999 opened this issue 5 years ago • 14 comments

Please describe the problem (or idea)

I have an idea Dark theme for image-sequencer.It would be better UI. I have also oppend same issue for community toolbox https://github.com/publiclab/community-toolbox/issues/155.

What happened just before the problem occurred? Or what problem could this idea solve?

What did you expect to see that you didn't?

Please show us where to look

http://sequencer.publiclab.org...

What's your PublicLab.org username?

singhav

This can help us diagnose the issue:

Browser, version, and operating system

Many bugs are related to these -- please help us track it down and reproduce what you're seeing!


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

avsingh999 avatar Mar 12 '19 14:03 avsingh999

@publiclab/mentors @jywarren @tech4GT @SidharthBansal What do you think about this I have also opened the same issue in community toolbox. Please review me. thanks : )

avsingh999 avatar Mar 12 '19 14:03 avsingh999

@avsingh999 can you please provide a mockup for this?

Divy123 avatar Mar 12 '19 17:03 Divy123

I guess we can add it as a option. So that the user chooses the one(dark mode or normal)

harshithpabbati avatar Mar 13 '19 09:03 harshithpabbati

I guess we can add it as a option. So that the user chooses the one(dark mode or normal)

That is good. But actually implementing dark mode will be difficult since we use bootstrap as our frontend framework. Will we have to override almost all the bootstrap classes ?

harshkhandeparkar avatar Mar 13 '19 09:03 harshkhandeparkar

@HarshKhandeparkar Yes, It would be difficult. Let's see for other reviews.

avsingh999 avatar Mar 13 '19 11:03 avsingh999

I think there are bootstrap themes... Maybe there's a dark theme?

On Wed, Mar 13, 2019, 7:28 AM Avkaran Singh [email protected] wrote:

@HarshKhandeparkar https://github.com/HarshKhandeparkar Yes, It would be difficult. Let's see for other reviews.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/851#issuecomment-472384297, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ5UF7_WDdqfZxbsKNoTgXsZfpv1Sks5vWOCqgaJpZM4brDDR .

jywarren avatar Mar 14 '19 15:03 jywarren

@jywarren maybe But I search and I found it's may be helpful https://bootswatch.com/darkly/ for this. thanks : )

avsingh999 avatar Mar 16 '19 01:03 avsingh999

Hi everyone I found some cool bootswatch dark themes:

cc @jywarren @publiclab/is-reviewers @avsingh999

harshkhandeparkar avatar Apr 08 '19 18:04 harshkhandeparkar

:-) cool!!!! awesome!

On Mon, Apr 8, 2019 at 2:35 PM Harsh Khandeparkar [email protected] wrote:

Hi everyone I found some cool bootswatch dark themes:

cc @jywarren https://github.com/jywarren @publiclab/is-reviewers https://github.com/orgs/publiclab/teams/is-reviewers @avsingh999 https://github.com/avsingh999

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/851#issuecomment-480952336, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ54ZyCFXc-ZPfaiexKXhur43g8Dyks5ve4vSgaJpZM4brDDR .

jywarren avatar Apr 08 '19 18:04 jywarren

@jywarren what is your thought on making the whole UI to react??

harshithpabbati avatar Apr 08 '19 18:04 harshithpabbati

:-) I think it's a positive direction -- but I really want to stabilize the existing system as much as possible so that some real-world use cases can be launched, before taking on a major UI refactoring. I'll write back soon to your question about UI tests, but I think that has to be part of it too! Thank you!!!

On Mon, Apr 8, 2019 at 2:55 PM Harshith pabbati [email protected] wrote:

@jywarren https://github.com/jywarren what is your thought on making the whole UI to react??

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/image-sequencer/issues/851#issuecomment-480960423, or mute the thread https://github.com/notifications/unsubscribe-auth/AABfJ67mIlLZllpcPhZkkeHGiaEHEhYZks5ve5CTgaJpZM4brDDR .

jywarren avatar Apr 08 '19 18:04 jywarren

@HarshKhandeparkar i have solved this issue so, can i open a PR for it ?

vivek-30 avatar Feb 26 '21 11:02 vivek-30

Go for it!

harshkhandeparkar avatar Feb 26 '21 14:02 harshkhandeparkar

Ok. And thank-you 😊

vivek-30 avatar Feb 26 '21 14:02 vivek-30