Fixed the step options being set in an infinite loop

[sjbcastro]

Fixes #1623

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
• [ ] code is in uniquely-named feature branch and has no merge conflicts
• [x] PR is descriptively titled
• [ ] ask @publiclab/is-reviewers for help, in a comment below
• [x] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

[welcome[bot]]

Thanks for opening this pull request! There may be some errors, but don't worry! We're here to help! 👍🎉😄

[codecov[bot]]

Codecov Report

Merging #1673 (d81027d) into main (853e719) will decrease coverage by 1.79%. The diff coverage is 46.48%.

:exclamation: Current head d81027d differs from pull request most recent head a0e2714. Consider uploading reports for the commit a0e2714 to get more accurate results

@@            Coverage Diff             @@
##             main    #1673      +/-   ##
==========================================
- Coverage   66.67%   64.88%   -1.80%     
==========================================
  Files         130      135       +5     
  Lines        2686     2828     +142     
  Branches      433      458      +25     
==========================================
+ Hits         1791     1835      +44     
- Misses        895      993      +98     

Impacted Files	Coverage Δ
src/InsertStep.js	79.41% <ø> (ø)
src/Modules.js	100.00% <ø> (ø)
src/modules/EdgeDetect/Module.js	100.00% <ø> (ø)
src/modules/WebglDistort/Module.js	2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js	3.63% <3.63%> (ø)
src/modules/Shadow/Module.js	44.30% <44.30%> (ø)
src/modules/Overlay/Module.js	93.18% <94.11%> (-1.69%)	:arrow_down:
src/modules/ColorHalftone/index.js	100.00% <100.00%> (ø)
src/modules/Colorbar/Module.js	100.00% <100.00%> (ø)
src/modules/Crop/Module.js	88.88% <100.00%> (ø)
... and 9 more

[sjbcastro]

Hi @HarshKhandeparkar just realised this pull request is still open. Are there any changes I need to make or can it be merged?

[harshkhandeparkar]

I am just a reviewer here (and oops I forgot to approve :stuck_out_tongue_closed_eyes:) so I can't merge it. @jywarren is the maintainer but I haven't seen him merge PRs in a while ¯_(ツ)_/¯

[gitpod-io[bot]]

[jywarren]

Hi all! Thanks, and sorry for the quietness recently. Am trying to review more regularly.

Looks like a couple test jobs failed... can you take a look at what's going wrong there? If you paste the output into a comment, we can debug together. Thanks!

[gitpod-io[bot]]