image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Fix Overlay module for gifs

Open ataata107 opened this issue 5 years ago • 4 comments

Concerns #1468 (<=== Replace 0000 with the Issue Number) ezgif com-video-to-gif (1)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • [ ] code is in uniquely-named feature branch and has no merge conflicts
  • [ ] PR is descriptively titled
  • [ ] ask @publiclab/is-reviewers for help, in a comment below
  • [ ] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

ataata107 avatar Feb 05 '20 23:02 ataata107

@publiclab/is-reviewers overlay is working now

ataata107 avatar Feb 06 '20 11:02 ataata107

@ataata107 if you are still working on this, can you please fix the error?

harshkhandeparkar avatar Jul 07 '20 15:07 harshkhandeparkar

@ataata107 Any updates on this?

govindgoel avatar Sep 21 '20 20:09 govindgoel

Hi @govindgoel @HarshKhandeparkar, as @ataata107 not active anymore. You can fix the issue in this PR if you're interested or we can close this PR. Thank you @ataata107 for taking dig at the issue :)

Thanks!

grvsachdeva avatar Sep 27 '20 13:09 grvsachdeva