image-sequencer
image-sequencer copied to clipboard
WebglDistort for GIF's
Concerns #1470 (<=== Replace 0000
with the Issue Number)
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [X] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
npm run test-all
- [X] code is in uniquely-named feature branch and has no merge conflicts
- [X] PR is descriptively titled
- [X] ask
@publiclab/is-reviewers
for help, in a comment below - [X] Insert-step functionality is working correct as expected.
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X
to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!
Codecov Report
Merging #1614 into main will increase coverage by
0.04%
. The diff coverage is9.52%
.
@@ Coverage Diff @@
## main #1614 +/- ##
==========================================
+ Coverage 66.67% 66.72% +0.04%
==========================================
Files 130 130
Lines 2686 2687 +1
Branches 433 433
==========================================
+ Hits 1791 1793 +2
+ Misses 895 894 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/modules/WebglDistort/Module.js | 4.54% <9.52%> (+2.24%) |
:arrow_up: |
Woohoo WebGL is also now working for gif's @publiclab/is-reviewers
@ataata107 could you share the cli output, thanks!