image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Added overline underline and strike in text overlay

Open niravasher opened this issue 5 years ago • 7 comments

Fixes #1585 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm run test-all
  • [x] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] ask @publiclab/is-reviewers for help, in a comment below
  • [x] Insert-step functionality is working correct as expected.

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

niravasher avatar Jan 31 '20 09:01 niravasher

strike

Screenshot from 2020-01-31 15-21-23

overline

Screenshot from 2020-01-31 15-19-13

underline

Screenshot from 2020-01-31 15-20-36 @aashna27 @ataata107

niravasher avatar Jan 31 '20 10:01 niravasher

Codecov Report

Merging #1602 into main will increase coverage by 10.29%. The diff coverage is 63.90%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1602       +/-   ##
===========================================
+ Coverage   55.11%   65.41%   +10.29%     
===========================================
  Files         117      132       +15     
  Lines        2344     2741      +397     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1793      +501     
+ Misses       1052      948      -104     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) :arrow_down:
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) :arrow_down:
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 100 more

codecov[bot] avatar Jan 31 '20 10:01 codecov[bot]

Screenshot from 2020-02-02 00-57-31

niravasher avatar Feb 01 '20 19:02 niravasher

Fixed the silly mistakes @blurry-x-face

niravasher avatar Feb 03 '20 18:02 niravasher

Updated PR once again @blurry-x-face

niravasher avatar Feb 04 '20 12:02 niravasher

done @blurry-x-face

niravasher avatar Feb 04 '20 17:02 niravasher

gitpod-io[bot] avatar Jul 07 '20 16:07 gitpod-io[bot]