image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Added Sketch Module

Open ataata107 opened this issue 5 years ago • 3 comments

Fixes #993

Concerns #694 ezgif com-video-to-gif (4)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [X] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • [X] code is in uniquely-named feature branch and has no merge conflicts
  • [X] PR is descriptively titled
  • [X] ask @publiclab/is-reviewers for help, in a comment below
  • [X] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

ataata107 avatar Jan 09 '20 22:01 ataata107

@publiclab/is-reviewers

Will refactor after your reviews

ataata107 avatar Jan 09 '20 22:01 ataata107

Codecov Report

Merging #1450 into main will increase coverage by 9.17%. The diff coverage is 65.98%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1450      +/-   ##
==========================================
+ Coverage   55.11%   64.29%   +9.17%     
==========================================
  Files         117      129      +12     
  Lines        2344     2627     +283     
  Branches      360      419      +59     
==========================================
+ Hits         1292     1689     +397     
+ Misses       1052      938     -114     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) :arrow_down:
examples/lib/defaultHtmlStepUi.js 11.29% <5.00%> (-0.90%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
src/modules/Sketch/Module.js 13.33% <13.33%> (ø)
src/util/getImageDimensions.js 15.38% <15.38%> (ø)
examples/lib/insertPreview.js 13.51% <22.22%> (ø)
src/modules/BlobAnalysis/Module.js 30.76% <33.33%> (+2.19%) :arrow_up:
src/modules/TextOverlay/Module.js 54.54% <33.33%> (+21.21%) :arrow_up:
... and 84 more

codecov[bot] avatar Jan 09 '20 22:01 codecov[bot]

gitpod-io[bot] avatar Jul 07 '20 19:07 gitpod-io[bot]