image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Added event to close button

Open ataata107 opened this issue 5 years ago • 4 comments

Fixes #1409 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [X] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • [X] code is in uniquely-named feature branch and has no merge conflicts
  • [X] PR is descriptively titled
  • [X] ask @publiclab/is-reviewers for help, in a comment below
  • [X] Insert-step functionality is working correct as expected.

ezgif com-video-to-gif (2)

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

ataata107 avatar Jan 02 '20 21:01 ataata107

@publiclab/is-reviewers

ataata107 avatar Jan 02 '20 21:01 ataata107

Codecov Report

Merging #1412 into main will increase coverage by 10.25%. The diff coverage is 63.77%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1412       +/-   ##
===========================================
+ Coverage   55.11%   65.37%   +10.25%     
===========================================
  Files         117      132       +15     
  Lines        2344     2744      +400     
  Branches      360      438       +78     
===========================================
+ Hits         1292     1794      +502     
+ Misses       1052      950      -102     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
src/ui/SetInputStep.js 13.84% <11.11%> (-0.44%) :arrow_down:
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) :arrow_down:
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
src/util/isGif.js 20.00% <20.00%> (ø)
... and 100 more

codecov[bot] avatar Jan 02 '20 22:01 codecov[bot]

@jywarren @keshav234156 can you review this one

ataata107 avatar Jan 14 '20 01:01 ataata107

gitpod-io[bot] avatar Jul 07 '20 19:07 gitpod-io[bot]