image-sequencer icon indicating copy to clipboard operation
image-sequencer copied to clipboard

Image #src fix

Open tsparksh opened this issue 5 years ago • 7 comments

Fixes #1241 (<=== Replace 0000 with the Issue Number)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with npm test
  • [x] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] ask @publiclab/is-reviewers for help, in a comment below
  • [x] Insert-step functionality is working correct as expected.

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software Please make sure to get at least two reviews before asking for merging the PR as that would make the PR more reliable on our part Thanks!

tsparksh avatar Dec 15 '19 14:12 tsparksh

Codecov Report

Merging #1359 into main will increase coverage by 10.29%. The diff coverage is 64.22%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #1359       +/-   ##
===========================================
+ Coverage   55.11%   65.41%   +10.29%     
===========================================
  Files         117      133       +16     
  Lines        2344     2744      +400     
  Branches      360      439       +79     
===========================================
+ Hits         1292     1795      +503     
+ Misses       1052      949      -103     
Impacted Files Coverage Δ
examples/lib/scopeQuery.js 18.51% <ø> (ø)
src/Modules.js 100.00% <ø> (ø)
src/modules/WebglDistort/Module.js 2.29% <0.00%> (ø)
src/ui/LoadImage.js 57.77% <0.00%> (+7.77%) :arrow_up:
src/ui/SetInputStep.js 12.90% <0.00%> (-1.39%) :arrow_down:
src/modules/ColorHalftone/Module.js 3.63% <3.63%> (ø)
examples/lib/defaultHtmlStepUi.js 11.35% <4.08%> (-0.85%) :arrow_down:
examples/lib/intermediateHtmlStepUi.js 11.11% <5.55%> (+0.94%) :arrow_up:
examples/lib/insertPreview.js 13.15% <20.00%> (-0.36%) :arrow_down:
src/util/getImageDimensions.js 20.00% <20.00%> (ø)
... and 103 more

codecov[bot] avatar Dec 15 '19 14:12 codecov[bot]

@tsparksh You have to claim a task on GCI dashboard first and then work on it. You've submitted a PR but have not accepted this task on GCI dashboard.

It's against the rules. Read 4.2

VladimirMikulic avatar Dec 23 '19 20:12 VladimirMikulic

Hey @VladimirMikulic, GCI task was taken by me when I submited this PR, but this is not a full solition of task (although I’m not at all sure that this task can be done) and so I abandoned the task

tsparksh avatar Dec 24 '19 00:12 tsparksh

I wrote about this here https://github.com/publiclab/image-sequencer/issues/1241#issuecomment-565813651

tsparksh avatar Dec 24 '19 00:12 tsparksh

I didn't know that, my apologies. It's just that we encountered a similar case, so that's why I commented.

VladimirMikulic avatar Dec 24 '19 00:12 VladimirMikulic

gitpod-io[bot] avatar Jul 07 '20 18:07 gitpod-io[bot]

@jywarren I think this should be mergeable.

harshkhandeparkar avatar Jul 07 '20 19:07 harshkhandeparkar