community-toolbox icon indicating copy to clipboard operation
community-toolbox copied to clipboard

Invert button isn't making a dark background

Open nstjean opened this issue 5 years ago • 13 comments

I noticed that the invert button is causing some weird issues in my browser. The background is being set to black, and then the body is being inverted, which changes it back to white.

FireShot Capture 198 - Community toolbox - code publiclab org

This can be fixed by applying the filter:invert to the html tag instead of the body tag and removing the background-color: rgb(17, 17, 17); on the body tag.

nstjean avatar Jan 08 '20 19:01 nstjean

Thanks for opening your first issue here! Please follow the issue template to help us help you 👍🎉😄 If you have screenshots to share demonstrating the issue, that's really helpful! 📸 You can make a gif too!

welcome[bot] avatar Jan 08 '20 19:01 welcome[bot]

@nstjean Can I take up the issue?

somenath1435 avatar Jan 09 '20 11:01 somenath1435

@somenath1435 Go ahead!

nstjean avatar Jan 09 '20 14:01 nstjean

@nstjean As per the latest codebase in "main" branch, the issue is not there(Atleast in my system). Please check.

somenath1435 avatar Jan 10 '20 17:01 somenath1435

Ahhh, I see! That's interesting, as it seems to behave differently on the server than it does in local even though it's the same code. Could you investigate a little bit? It appears to have to do with the margin of the body tag.

nstjean avatar Jan 10 '20 18:01 nstjean

If it's still incomplete means, may I take it please?

sunguru98 avatar Jan 12 '20 04:01 sunguru98

Hi @sunguru98 , @somenath1435 is investigating this issue.

nstjean avatar Jan 13 '20 14:01 nstjean

@sunguru98 you can take this issue

somenath1435 avatar Jan 13 '20 14:01 somenath1435

i want to take this issue!

aashimgarg avatar Jan 16 '20 09:01 aashimgarg

@aashimgarg The stage is yours.

sunguru98 avatar Jan 16 '20 13:01 sunguru98

i think some of your npm dependencies are not installed.

aashimgarg avatar Jan 19 '20 09:01 aashimgarg

Hi, @nstjean @somenath1435 @aashimgarg and @sunguru98 can I work on this?

YogeshSharma01 avatar Feb 08 '21 11:02 YogeshSharma01

Hi @nstjean Can I work on this?

GuptaTanisha avatar Jan 11 '22 09:01 GuptaTanisha