community-toolbox icon indicating copy to clipboard operation
community-toolbox copied to clipboard

Published 20 hours ago • verified publisher icon publiclab

Made "Back to top" button sticky

Open somenath1435 opened this issue 5 years ago • 10 comments

fixes #301 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with rake test
  • [x] code is in uniquely-named feature branch and has no merge conflicts
  • [x] PR is descriptively titled
  • [x] PR body includes fixes #0000-style reference to original issue #
  • [x] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

somenath1435 avatar Dec 08 '19 20:12 somenath1435

@Rishabh570 margin-left: auto will push the content to right. Now, I,ve shifted the button so that it is not overlapping with the contents.

somenath1435 avatar Jan 10 '20 16:01 somenath1435

@jywarren @Rishabh570 please review the current changes

somenath1435 avatar Jan 18 '20 23:01 somenath1435

@somenath1435 Can you please share a screenshot of changes?

Thanks.

Rishabh570 avatar Jan 23 '20 11:01 Rishabh570

Here is the screenshot: Screenshot from 2020-01-24 10-01-33

somenath1435 avatar Jan 23 '20 23:01 somenath1435

@somenath1435 It's weird but the changes made here are not showing the same effect on my local version...can you re-confirm it by rebasing your branch and showing the GIF, please.

Rishabh570 avatar Jan 31 '20 17:01 Rishabh570

@Rishabh570 Can I work on this.

govindgoel avatar Feb 08 '20 12:02 govindgoel

Hi @somenath1435, are you working on it? If not, @govindgoel can go ahead.

Thanks!

Rishabh570 avatar Feb 11 '20 05:02 Rishabh570

@govindgoel go ahead

somenath1435 avatar Feb 21 '20 22:02 somenath1435

I guess we should close this pull request. What are your thoughts @somenath1435 , @Rishabh570 ?

pydevsg avatar Oct 01 '20 19:10 pydevsg

I have commented on the issue https://github.com/publiclab/community-toolbox/issues/301 and willing to fix this cause it looks weird in the middle and needs to be fixed asap.

pydevsg avatar Oct 01 '20 19:10 pydevsg