PublicLab.Editor icon indicating copy to clipboard operation
PublicLab.Editor copied to clipboard

made responsive for mobile screens

Open Charu271 opened this issue 4 years ago • 11 comments

issue: #526 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • [ ] code is in uniquely-named feature branch and has no merge conflicts
  • [ ] PR is descriptively titled
  • [ ] PR body includes fixes #0000-style reference to original issue #
  • [ ] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

Charu271 avatar Dec 30 '20 20:12 Charu271

Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help. Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory. Dangerbot will test out your code and reply in a bit with some pointers and requests. Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?

welcome[bot] avatar Dec 30 '20 20:12 welcome[bot]

gitpod-io[bot] avatar Dec 30 '20 20:12 gitpod-io[bot]

@Charu271 please add the screenshots of the changes you have made. To be precise you should add before and after the changes screenshot. Also, always point to the issue you have made this pull request.

NitinBhasneria avatar Dec 31 '20 10:12 NitinBhasneria

image

image

image

image

image

image

image

image

Above are the screenshots in mobile view. It refers to issue #526 Sorry I haven't took the screenshots before changes

Charu271 avatar Dec 31 '20 19:12 Charu271

Changes look good. @jywarren @Sagarpreet @cesswairimu have a look.

NitinBhasneria avatar Jan 05 '21 12:01 NitinBhasneria

oh wow!! these look awesome :rocket: ..fantastic job @Charu271, could you please do a rebase,...also I will request @sagarpreet-chadha for review here. Thanks a lot for working on this :tada: :tada:

cesswairimu avatar Jan 06 '21 07:01 cesswairimu

Thank you @NitinBhasneria @cesswairimu @Sagarpreet . @cesswairimu Do I need rebase my branch?

Charu271 avatar Jan 06 '21 18:01 Charu271

@Charu271 yes please...after that we are good to merge. Thanks

cesswairimu avatar Jan 06 '21 18:01 cesswairimu

@cesswairimu I rebased my branch but its showing already up to date

Charu271 avatar Jan 07 '21 10:01 Charu271

Oh so sorry, my bad 🤦...thought we were at plots2..please ignore my comment

cesswairimu avatar Jan 07 '21 10:01 cesswairimu

No issues @cesswairimu

Charu271 avatar Jan 07 '21 10:01 Charu271