PublicLab.Editor
PublicLab.Editor copied to clipboard
made responsive for mobile screens
issue: #526 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
grunt jasmine
- [ ] code is in uniquely-named feature branch and has no merge conflicts
- [ ] PR is descriptively titled
- [ ] PR body includes
fixes #0000
-style reference to original issue # - [ ] ask
@publiclab/reviewers
for help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X
to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!
Thanks for opening this pull request! This space is protected by our Code of Conduct - and we're here to help.
Please make sure you've bumped up the version number in the repository's package.json file and that you've incorporated your changes in the /dist/ sub-directory.
Dangerbot
will test out your code and reply in a bit with some pointers and requests.
Also please refer here for installation help 💿
There may be some errors, but don't worry! We'll work through them with you! 👍🎉😄
It would be great if you can tell us your Twitter handle so we can thank you properly?
@Charu271 please add the screenshots of the changes you have made. To be precise you should add before and after the changes screenshot. Also, always point to the issue you have made this pull request.
Above are the screenshots in mobile view. It refers to issue #526 Sorry I haven't took the screenshots before changes
Changes look good. @jywarren @Sagarpreet @cesswairimu have a look.
oh wow!! these look awesome :rocket: ..fantastic job @Charu271, could you please do a rebase,...also I will request @sagarpreet-chadha for review here. Thanks a lot for working on this :tada: :tada:
Thank you @NitinBhasneria @cesswairimu @Sagarpreet . @cesswairimu Do I need rebase my branch?
@Charu271 yes please...after that we are good to merge. Thanks
@cesswairimu I rebased my branch but its showing already up to date
Oh so sorry, my bad 🤦...thought we were at plots2..please ignore my comment
No issues @cesswairimu