PublicLab.Editor
PublicLab.Editor copied to clipboard
publiclab
Adjust CSS styling of rich text toolbar to Bootstrap 4 for consistency
I think the lines of code could be somewhere around here?
https://github.com/publiclab/PublicLab.Editor/blob/cf1fc4a9c4b70afaede856bac214e27388ab6cfa/src/adapters/PublicLab.Woofmark.js#L372
See how the buttons here don't match -- i think the basic buttons are via woofmark but the black-outlined ones are the ones we've added programmatically after woofmark is loaded. We'd love help with this, it probably will take some trial and error but isn't such a complex change!
Originally posted by @jywarren in https://github.com/publiclab/PublicLab.Editor/issues/663#issuecomment-736821577 (cc @keshav234156, noting I've split this out!)
@jywarren hi, could i take this bug? would be my first open source contribution
are you looking to change the outline (make all the buttons outlined) or you want them to be basic (via woofmark)?
@jywarren Hello! I am fairly new to contributing to major repositories on Github in-fact this is my very first comment. I started working on this issue today and found out the fix for it. Just wanted to share a picture of the result before I created a new branch. The changes were very minor and I want to know if its correct!
I also fixed the Custom Insert button in responsive view.
Please correct me if I am wrong and you expected something else!
Hi, @jywarren, I'm Goodness, an Outreachy applicant interested in contributing to the "Refine the Public Lab Rich Editor" project. I would like to if this issue is still open and if I can work on it.
Hi @Goodiec we'd love a contribution here. I wonder if https://github.com/publiclab/PublicLab.Editor/pull/705 already gets at part of it? However i wonder if it could be done more efficiently in a single CSS selector instead of individually for each.
I'm also not sure if this recent tweak I made may have resolved the issue as well?
https://github.com/publiclab/PublicLab.Editor/commit/b1cb34626b1c3acf8a9d87f12c4ee4830d5f8471
But, if you can try it out locally with the latest code to confirm, we should be able to close this issue one way or another. Thank you!!!
Hi @Goodiec we'd love a contribution here. I wonder if #705 already gets at part of it? However i wonder if it could be done more efficiently in a single CSS selector instead of individually for each.
I'm also not sure if this recent tweak I made may have resolved the issue as well?
But, if you can try it out locally with the latest code to confirm, we should be able to close this issue one way or another. Thank you!!!
Sure, I'll try that. Thank you!
@RaviAnand111 I think this issue has been resolved. I checked on my local environment and all of the buttons match.
Hey @TildaDares, I checked my local environment and all the buttons do not match,
Do you know why is this happening?
Thanks @TildaDares , I just had this 1 doubt, should I create a different branch every time I work on different issue or should I work in the main branch ?
@RaviAnand111 It's better to create a different branch when you work on different issues so that you can isolate your changes from your main branch.
ok, now I understand, ThankYou for explaining, you are like an elder sister who helps me whenever I am in trouble, ThankYou
ok, now I understand, ThankYou for explaining, you are like an elder sister who helps me whenever I am in trouble, ThankYou
Lol yeah, she's amazing. In my case, she'd always help me with very useful resources. You are doing a great job as well my friend @RaviAnand111
Thanks alot, @NARUDESIGNS, it is really a complement, getting thumps up from you guys. ❤️
@RaviAnand111 I think someone might have worked on this before. Here - https://github.com/publiclab/PublicLab.Editor/pull/705 This is a very good job by the way!
yeah, #705 has already solved it, so should I leave it and work on some other issue ?, yeah, sure you can tell me about UI changes if you want. Thanks