PublicLab.Editor icon indicating copy to clipboard operation
PublicLab.Editor copied to clipboard

Published 20 hours ago • verified publisher icon publiclab

Custom insert map

Open keshav234156 opened this issue 4 years ago • 11 comments

Concerns #419 Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt jasmine
  • [ ] code is in uniquely-named feature branch and has no merge conflicts
  • [ ] PR is descriptively titled
  • [ ] PR body includes fixes #0000-style reference to original issue #
  • [ ] ask @publiclab/reviewers for help, in a comment below

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.

Thanks!

keshav234156 avatar Jun 27 '20 14:06 keshav234156

@jywarren Please review!!

keshav234156 avatar Jun 30 '20 15:06 keshav234156

@NitinBhasneria @shreyaa-s @Shulammite-Aso Please review!!

keshav234156 avatar Jun 30 '20 16:06 keshav234156

Hi @keshav234156! Also wanted to note that now that we have UI tests in Jes (#541) maybe you could add a simple test to demonstrate this? As well as a screenshot? Thank you so much!

jywarren avatar Jun 30 '20 16:06 jywarren

@jywarren Added the test!!

keshav234156 avatar Jul 07 '20 05:07 keshav234156

@shreyaa-s @Shulammite-Aso @NitinBhasneria Please review!!

keshav234156 avatar Jul 07 '20 05:07 keshav234156

Oh this is great. Can you share a screenshot as well? Once we get #475 and #553 fixed, these will be auto-generated, too!

jywarren avatar Jul 07 '20 19:07 jywarren

gitpod-io[bot] avatar Jul 16 '20 16:07 gitpod-io[bot]

Hi @keshav234156 i hope you're doing well. I was wondering if you're available at all to try to wrap this up? No pressure, it'd just be nice to see merged! Thanks again for your work!!!

jywarren avatar Nov 24 '20 22:11 jywarren

@jywarren can we just postpone it for another 1 week. Will surely do it after that.

keshav234156 avatar Nov 25 '20 06:11 keshav234156

No problem or rush at all, @keshav234156 -- much appreciated.

jywarren avatar Dec 01 '20 19:12 jywarren

Hi @keshav234156 did you have any availability to wrap this up as it's almost there? If not, we can try to find someone else to pitch in, thank you!!!!

jywarren avatar Feb 23 '21 20:02 jywarren