Title bar Improvement

[NitinBhasneria]

Currently, when we enter the title in the title module, we can draw others to our work. But once added we can't see the added peoples and so we can't confirm the are added. Another thing is we can't remove the person once added. Expected: We should have a row of the peoples added and beside it, there should be a remove button.

Things needed to be added.

• [x] The added suggestions should not be shown when visited again on the title bar.
• [x] The added suggestion should be shown in a different place.
• [x] The added suggestion should have the remove suggestion or X button.
• [x] Once we add any related work, it fades out. For adding another we have to key-down. This needs to be fixed. PR #534

[NitinBhasneria]

@nstjean @cesswairimu @VladimirMikulic please review.

[nstjean]

Yes I see what you mean! I think when something is clicked on it adds it to the tag list here:

So yes you can delete it, but only if you know what that is! It would be much better to have a list of people who will be notified, with an "x" button if you want to remove them. Then this tag would get added at the time the post button is clicked. Take a look at how the lat and lon tags are added from the map section.

[NitinBhasneria]

@VladimirMikulic @jywarren I cant see the related work suggestion in title bar when I run the development in localhost:3000 while I can see them in publiclab.org/post. I am confused because of this. Please clear my doubt. Thank you.

[VladimirMikulic]

@NitinBhasneria you need plots2 running locally (server). Instructions are in README.

[NitinBhasneria]

Thanks, @VladimirMikulic but I have tried it with plots2 too and I am having the same result. Have a look at this.

[VladimirMikulic]

Test DB is probably empty and doesn't have any posts to suggest. That's why there are no suggestions. You could add some posts in DB and then it will work.

[NitinBhasneria]

@VladimirMikulic If you know can you please guide how to add the posts in DB. Thank you.

[VladimirMikulic]

@Uzay-G knows :)

[Uzay-G]

@VladimirMikulic If you know can you please guide how to add the posts in DB. Thank you.

See https://github.com/publiclab/plots2#login to login and then simply create a new post at the /post endpoint to create new posts.

[NitinBhasneria]

Thinks to be added.

1. The tagged posts will be seen in title module.
2. Once the post is tagged in title module it can be removed.
3. Suggestions will be provided in the Tag module. @VladimirMikulic @govindgoel @cesswairimu @keshav234156 @Shulammite-Aso @jywarren @shreyaa-s
   Can you please give your views on this.

[cesswairimu]

Great @NitinBhasneria :tada: on point 1: will these be visible on hover? ...love the idea :100:

[NitinBhasneria]

Great @NitinBhasneria on point 1: will these be visible on hover? ...love the idea

Yes @cesswairimu

[ebarry]

Mentioning that the "Read more >>" link reloads the page, rather than provide information about this feature. This is my first problem with this feature.

Testing this feature further, i recorded a gif that shows the help text blinking on an off, and shows how after typing and retyping in the title bar, the suggestions get "stuck" on what was previously typed which is buggy.

More testing: clicking 'Add' on one of the suggested notes adds a powertag marking your post as a "response" to that note. It does not actually add any people or users in to your content. It does make me wonder if the suggested notes that appear are selected from notes marked 'activity', because those are the only type of notes that can be responded to in that way.

Summary

Despite being extremely familiar with all content on the publiclab.org website, including tags and usernames, this feature was very confusing to me, until i tracked down that this feature is autosuggesting activities to post responses to. This purpose must be evaluated along with how it functions.

Thank you for reading!

[NitinBhasneria]

Thanks @ebarry. Are there existing documents on the title bar working? @jywarren @emilyashley @VladimirMikulic @govindgoel

[NitinBhasneria]

Another Error: Once we have added the related post and if we go again on the title bar it will show the added post in related(suggestion).

[Shulammite-Aso]

Yes I see what you mean! I think when something is clicked on it adds it to the tag list here:

So yes you can delete it, but only if you know what that is! It would be much better to have a list of people who will be notified, with an "x" button if you want to remove them. Then this tag would get added at the time the post button is clicked. Take a look at how the lat and lon tags are added from the map section.

my observation is, like @nstjean had mention here, when you click on add it does actually add the response request tag to the tag list below. I didn't see this as a bug initially, but if this is not the best approach, an alternative approach will be to list the people that will get added close to the title field, and then perhaps add them to the tag list after we click on publish.

[NitinBhasneria]

Yes I see what you mean! I think when something is clicked on it adds it to the tag list here: So yes you can delete it, but only if you know what that is! It would be much better to have a list of people who will be notified, with an "x" button if you want to remove them. Then this tag would get added at the time the post button is clicked. Take a look at how the lat and lon tags are added from the map section.

my observation is, like @nstjean had mention here, when you click on add it does actually add the response request tag to the tag list below. I didn't see this as a bug initially, but if this is not the best approach, an alternative approach will be to list the people that will get added close to the title field, and then perhaps add them to the tag list after we click on publish.

Yea, this will be the right approach. And without this, the remove tag won't work.

[cypherean]

1. For the read more, we can show details on hover or open a small dialog box which does not interfere with the current page.
2. Yes, we need to refine the suggestions with: checking if a post is already added and making a new search everytime the text in title bar is changed.
3. Most importantly, the description says Does your work relate to one of these? Click to alert the contributors. Which does not indicate it being added as a response to their work. It's more of a similar post thing. And to the user the the numbers and id wont mean anything. If we show it as response:18995 the user won't understand which post he has already added. And if he wishes to remove one later on a second thought, it would end up being trial and error until he remembers the exact sequence in which he added the posts. And one thing I noticed, like in Nitin's GIF, that as soon as we select one post the suggestions collapse. Was the feature implemented keeping in mind that the user is writing a response to a single post? These are some things that we could give a thought in the changes that we introduce.

[NitinBhasneria]

1. For the read more, we can show details on hover or open a small dialog box which does not interfere with the current page.
2. Yes, we need to refine the suggestions with: checking if a post is already added and making a new search everytime the text in title bar is changed.
3. Most importantly, the description says Does your work relate to one of these? Click to alert the contributors. Which does not indicate it being added as a response to their work. It's more of a similar post thing. And to the user the the numbers and id wont mean anything. If we show it as response:18995 the user won't understand which post he has already added. And if he wishes to remove one later on a second thought, it would end up being trial and error until he remembers the exact sequence in which he added the posts. And one thing I noticed, like in Nitin's GIF, that as soon as we select one post the suggestions collapse. Was the feature implemented keeping in mind that the user is writing a response to a single post? These are some things that we could give a thought in the changes that we introduce.

Thanks @shreyaa-sharmaa for removing we will add the response when the publish button is clicked.

[NitinBhasneria]

As @shreyaa-s said the title bar suggestion says Does your work relate to one of these? Click to alert the contributors but this does not notify the contributors instead this just add the tag as a response(as @ebarry pointed out). For notifying the authors(contributors) I found this in the code editor.tagsModule.el.find('input').tokenfield('createToken', 'notify:' + result.author); but this is commented out and is pending in https://github.com/publiclab/plots2/issues/646. Thinking about all this I am little confused now. What are the expectation from adding the suggested post? @jywarren @ebarry @emilyashley @VladimirMikulic @govindgoel please guide.

[ebarry]

Wow, great investigations all 🌟🤝 Thank you @NitinBhasneria @shreyaa-sharmaa @Shulammite-Aso @cesswairimu @VladimirMikulic @cesswairimu @nstjean 💐 @emilyashley, @jywarren , and myself will speak today (a few hours from now) and write back here ASAP.

[jywarren]

Just chiming in with a few notes:

after typing and retyping in the title bar, the suggestions get "stuck" on what was previously typed which is buggy. (@ebarry)

I believe this is related to performance issues -- basically as you keep typing, the number of requests generated overwhelms our server and it chokes at some point, causing the stall. I don't have a strong suggestion here except to further throttle how often new results are requested, with the hope that although it would be less responsive, it would not /completely/ stall out the server. Read more here, however: https://github.com/publiclab/plots2/issues/5015

It does not actually add any people or users in to your content.

@ebarry did you mean that you assumed it would add usernames to the content to alert them? The original spec for this feature was that the tag alone would be enough to trigger an email notification, which @NitinBhasneria found in this issue: https://github.com/publiclab/plots2/issues/646.

We could decide we don't want that any more (up to @ebarry / @publiclab/community-reps) and then we would just want to change the wording of the help text that currently says Click to alert the contributors to clarify.

Re: @Shulammite-Aso:

I didn't see this as a bug initially, but if this is not the best approach, an alternative approach will be to list the people that will get added close to the title field, and then perhaps add them to the tag list after we click on publish.

I see what you're saying in terms of how users may expect to see a list of people somewhere and the tags are far below and not very visible.

For the read more, we can show details on hover or open a small dialog box which does not interfere with the current page.

Cool, what about adding a target="_blank" attribute to each Read More link, so it opens in a new window? a pretty minimal simple fix.

Yes, we need to refine the suggestions with: checking if a post is already added and making a new search everytime the text in title bar is changed.

If so, we should do this only on the client side - i.e the server-side request should remain simple, without "exclusions" but we can filter on the client side before displaying? That will keep our API code as simple as possible.

It's more of a similar post thing.

This is totally right, and if we drop https://github.com/publiclab/plots2/issues/646 we can just modify the help text to reflect this more clearly and not mention alerting, which could address @ebarry's note on ambiguity of the feature as well.

@ebarry (as a @publiclab/community-reps member) had also suggested that this feature is not very critical in any case. It's original function was to help related work on the site to remain inter-connected, but if @publiclab/community-reps feel this is not working well, or that is not a priority, perhaps we should look to resolve any ambiguities or major bugs in as minimal a way as possible, so as to spend more time on other issues.

So, I support:

• [ ] adopting @NitinBhasneria's fix in #534 to clarify the UI flow
• [ ] dropping https://github.com/publiclab/plots2/issues/646 and rewording the help text (perhaps also in #534
• [ ] adding target="_blank" attributes to Read More links
• [ ] essentially not worrying about anything else; the filtering of existing related posts seems pretty simple so if someone else wants to take that up, great, but otherwise we should be all good here, no?

Thanks, all!

[ebarry]

I support this path, thank you all!

[jywarren]

Also some good docs on how this system works in #77, and some background in #95 !

[NitinBhasneria]

So what should be put in replacement of Click to alert the contributors. I guess Click to tag the related work will be better.

[NitinBhasneria]

All the work are completed have a look at #534