PublicLab.Editor
PublicLab.Editor copied to clipboard
publiclab
added modal for title
Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!
- [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with
grunt jasmine - [x] code is in uniquely-named feature branch and has no merge conflicts
- [x] PR is descriptively titled
- [x] PR body includes
fixes #403-style reference to original issue # - [x] ask
@publiclab/reviewersfor help, in a comment below
We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!
If tests do fail, click on the red X to learn why by reading the logs.
Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software
We have a loose schedule of reviewing and pulling in changes every Tuesday and Friday, and publishing changes on Fridays.
Thanks!
fixes #403
@VladimirMikulic . I have exams till 6th, hence a bit slow in contributing, but will keep working
@VladimirMikulic used inline css styling to prevent !important, also used btn-light. Please review
Done @VladimirMikulic please merge this. Also I need your help for my proposal for Public Lab Editor. I am DM'd you on gitter channel. Please reply there :smile:
@niravasher I know I told you that was the last change, but we have one more that really matters.
It would be great if you could make the modal to look like the one on the first picture. The current modal's items are squished and the title's font doesn't fit.
(HINT: margin-top: 0.5rem, title's font: "Helvetica Neue" :)
This is how it looks @VladimirMikulic
I must have missed this folks... @niravasher do you mind rebasing this to that we can have it merged? Thanks everyone :tada:
