PublicLab.Editor icon indicating copy to clipboard operation
PublicLab.Editor copied to clipboard

Clicking on "read more..." takes to https://publiclab.github.io/PublicLab.Editor/examples/

Open niravasher opened this issue 5 years ago • 8 comments

Please describe the problem (or idea)

Some more content about the title should be provided

Please show us where to look

https://publiclab.github.io/PublicLab.Editor/examples

What's your PublicLab.org username?

niravasher

Browser, version, and operating system

ubuntu 19.04


Thank you!

Your help makes Public Lab better! We deeply appreciate your helping refine and improve this site.

To learn how to write really great issues, which increases the chances they'll be resolved, see:

https://publiclab.org/wiki/developers#Contributing+for+non-coders

niravasher avatar Feb 18 '20 09:02 niravasher

Screenshot from 2020-02-18 14-57-58 The read more below the title goes to editor official website. @VladimirMikulic

niravasher avatar Feb 18 '20 09:02 niravasher

We should fix this. Maybe displaying a modal that shows guidelines for the best title?

VladimirMikulic avatar Feb 18 '20 11:02 VladimirMikulic

Ok, working on this

niravasher avatar Feb 19 '20 08:02 niravasher

"read more" Has been imported from the titleModule inside modules folder. Attaching an onclick function to this gives an error. What should I do ? @VladimirMikulic

niravasher avatar Feb 19 '20 11:02 niravasher

You can simply modify the line 25 from the title module to suit our needs.

VladimirMikulic avatar Feb 19 '20 12:02 VladimirMikulic

Simply modify line 25 as in you want to link to a new page like https://publiclab.org/wiki/power-tags or open up just a new modal. Because opening up a new modal, I need to create static HTML and CSS for modal and access that from publiclab.titleModule.js and then have close functionality. @VladimirMikulic @vaibhavmatta

niravasher avatar Feb 21 '20 18:02 niravasher

@niravasher you can use existing Bootstrap classes to display a modal. There is no need to code a custom modal.

VladimirMikulic avatar Feb 21 '20 18:02 VladimirMikulic

Works

niravasher avatar Feb 21 '20 19:02 niravasher