PublicLab.Editor icon indicating copy to clipboard operation
PublicLab.Editor copied to clipboard

Update font format in section 3

Open IgorWilbert opened this issue 6 years ago • 29 comments

Hi, this is a first-timers-only issue. This means we've worked to make it more legible to folks who either haven't contributed to our codebase before, or even folks who haven't contributed to open source before.

If that's you, we're interested in helping you take the first step and can answer questions and help you out as you do. Note that we're especially interested in contributions from people from groups underrepresented in free and open source software!

We know that the process of creating a pull request is the biggest barrier for new contributors. This issue is for you 💝

If you have contributed before, consider leaving this one for someone new, and looking through our general help wanted issues. Thanks!

🤔 What you will need to know.

Nothing. This issue is meant to welcome you to Open Source :) We are happy to walk you through the process.

📋 Step by Step

  • [ ] 🙋 Claim this issue: Comment below. If someone else has claimed it, ask if they've opened a pull request already and if they're stuck -- maybe you can help them solve a problem or move it along!

  • [ ] 📝 Update: this will fix #241. All that needs to be done is replace this line

https://github.com/publiclab/PublicLab.Editor/blob/94a549c6e6fcbc0d5ef8e6e3ebbf6322b46e748a/examples/index.html#L134

With this line <p class="ple-map-content"><b>By place name:</b></p>. This line https://github.com/publiclab/PublicLab.Editor/blob/94a549c6e6fcbc0d5ef8e6e3ebbf6322b46e748a/examples/index.html#L139 With this line <p class="ple-map-content"><b>By entering co-ordinates:</b></p>.

And finally, paste the following line (with the same indentation/format of the rest of the code)

.ple-map-content { font-size: 16px; }

on the file named PublicLab.Editor/dist/PublicLab.Editor.css, just after line number 36.

  • [ ] 💾 Commit your changes

  • [ ] 🔀 Start a Pull Request. There are two ways how you can start a pull request:

  1. If you are familiar with the terminal or would like to learn it, here is a great tutorial on how to send a pull request using the terminal.

  2. You can also edit files directly in your browser and open a pull request from there.

  • [ ] 🏁 Done Ask in comments for a review :)

🤔❓ Questions?

Leave a comment below!

Is someone else already working on this?

We encourage you to link to this issue by mentioning the issue # in your pull request, so we can see if someone's already started on it. If someone seem stuck, offer them some help! Otherwise, take a look at some other issues you can help with. Thanks!

(This issue was created by First-Timers-Bot.)

IgorWilbert avatar Jan 24 '19 09:01 IgorWilbert

please, can I work on this

NitinMore7 avatar Jan 24 '19 12:01 NitinMore7

Hi @NitinMore7, go ahead and feel free to ask your doubts here. Thanks!

grvsachdeva avatar Jan 24 '19 12:01 grvsachdeva

so I need to clone this repo, make the given changes & then commit them and start a pull request ,is that's right?

NitinMore7 avatar Jan 24 '19 12:01 NitinMore7

@NitinMore7 You'll need to clone your forked repo instead of this one.

rexagod avatar Jan 24 '19 12:01 rexagod

Its done can you please check and confirm

NitinMore7 avatar Jan 24 '19 12:01 NitinMore7

Can I work on this?

akshaygupta533 avatar Jan 24 '19 12:01 akshaygupta533

@akshaygupta533 please check other FTO issues, @NitinMore7 already claimed this one, sorry. @NitinMore7 did you remember to open a PR?

IgorWilbert avatar Jan 24 '19 12:01 IgorWilbert

@IgorWilbert i just did

NitinMore7 avatar Jan 24 '19 12:01 NitinMore7

Good job @NitinMore7, thanks! Do you know how to squash your commits (turn your commits into a single commit with all the changes)? Would you mind doing it?

IgorWilbert avatar Jan 24 '19 12:01 IgorWilbert

@IgorWilbert how do I squash my commits if I've already pushed them

NitinMore7 avatar Jan 24 '19 13:01 NitinMore7

@NitinMore7 you will have to rebase your branch. Run the command $ git rebase -i HEAD~4 and in the text editor that comes up, replace the words "pick" with "squash", except for the one at the top of the list. Then use $ git push origin branch-name --force to push to upstream. Please see this page for reference, and ask for help if something goes wrong. This can be a bit annoying to make.

IgorWilbert avatar Jan 24 '19 14:01 IgorWilbert

I've squashed those commits into one can you please check and confirm it

NitinMore7 avatar Jan 25 '19 02:01 NitinMore7

Hi @NitinMore7, please paste the link of your PR here or tag this issue in the PR. Thanks!

grvsachdeva avatar Jan 27 '19 15:01 grvsachdeva

https://github.com/publiclab/PublicLab.Editor/pull/253

NitinMore7 avatar Jan 29 '19 02:01 NitinMore7

Hello, I think the issue is still open, If yes then can I work on this?

lohitha02 avatar Feb 18 '19 05:02 lohitha02

this issue has a PR open at #253

grvsachdeva avatar Feb 18 '19 09:02 grvsachdeva

Hi, I am an outreachy applicant. Can i work on this issue?

Kirti2502 avatar Mar 08 '20 10:03 Kirti2502

Hey! I am applying to Outreachy. I have no experience in open source. Can I work on this?

Srija616 avatar Mar 08 '20 17:03 Srija616

Hello @Kirti2502 and @Srija616 I'm also an outreachy applicant, and looking to get started contributing to this project by working on the first-time-only issues. But this issue as well as all other first-time-only issues I've come across seem to have been claimed by someone else already.

I'm thinking of asking the mentors and reviewers for this project if more FTO issues can be created for us, or if we can go ahead to create these issues by ourselve. What do you two think?

Shulammite-Aso avatar Mar 09 '20 07:03 Shulammite-Aso

Hey Sure, in fact I mailed the mentors however they are yet to reply. Apart from the FTOs we should also ask what else can we contribute for the application.

On Mon, 9 Mar 2020, 13:22 Shulammite-Aso, [email protected] wrote:

Hello @Kirti2502 https://github.com/Kirti2502 and @Srija616 https://github.com/Srija616 I'm also an outreachy applicant, and looking to get started contributing to this project by working on the first-time-only issues. But this issue as well as all other first-time-only issues I've come across seem to have been claimed by someone else already.

I'm thinking of asking the mentors and reviewers for this project if any project if more FTO issues can be created for us, or if we can go ahead to create these issues by ourselve. What do you two think?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/PublicLab.Editor/issues/251?email_source=notifications&email_token=AICWZCUOWHWYISJ6CVF7RULRGSNZ7A5CNFSM4GSCAYW2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEOGALII#issuecomment-596379041, or unsubscribe https://github.com/notifications/unsubscribe-auth/AICWZCSMW5JULARSXEDNMBDRGSNZ7ANCNFSM4GSCAYWQ .

Srija616 avatar Mar 09 '20 07:03 Srija616

Good one. I should probably tag them here, if that will mean a quicker response.

Shulammite-Aso avatar Mar 09 '20 08:03 Shulammite-Aso

Hello @emilyashley @jywarren

Can you please suggest a way around this? https://github.com/publiclab/PublicLab.Editor/issues/251#issuecomment-596379041

Shulammite-Aso avatar Mar 09 '20 08:03 Shulammite-Aso

@Shulammite-Aso

Hi! I am also an Outreachy applicant; have the mentors @jywarren and @emilyashley reached out to you? I was about to contact them via email until I read this thread. Thanks in advance.

nicoleiocana avatar Mar 25 '20 14:03 nicoleiocana

Hello! @nicoleiocana

I think the best way to reach out to the community is through the chat Chanels. There's a link to the chat Chanel on outreachy project description page, you can check it out if you have not already.

Also you can mention the mentors on the chat channels if you have any question for them.

Shulammite-Aso avatar Mar 25 '20 17:03 Shulammite-Aso

Hey! This issue is still open. Can I work on this? I've never contributed to open source before. I'm trying to learn.

vaishnavighiradkar avatar Jan 06 '22 11:01 vaishnavighiradkar

I worked on this issue please check that.

MAYANK816 avatar May 22 '22 07:05 MAYANK816

Is this issue still open? I would like to work on it.

joannasjohnraj avatar Aug 23 '22 04:08 joannasjohnraj

I find you all very friendly. I am newbie to open source added to it, and have no one around to ask for guidance not even one , just a first-generation learner who want to learn new things but after hours spending seeing videos of open source I just cannot understand there are so many files,please help me

ghost avatar Sep 30 '22 13:09 ghost

i have fixed this issue please review it @IgorWilbert

UmeraGhori avatar Sep 27 '23 08:09 UmeraGhori