Leaflet.DistortableImage
Leaflet.DistortableImage copied to clipboard
publiclab
Replace example images with an aerial image
The example images should really be aerial photos, looking downward, as usable on MapKnitter.org -- not oblique angles. I know we discussed this but let's please replace these so that they make more sense for actual map stitching -- here's an example image that's an appropriate size and has some nice visual features:
https://s3.amazonaws.com/grassrootsmapping/warpables/315613/img02_medium.jpeg
This should go in /examples/index.html as well as /examples/select.html
It's from https://mapknitter.org/maps/museum-park-01-rotterdam, and there are other images that could be used in select.html so that there are fewer of the same image, so it's a more realistic example:
https://s3.amazonaws.com/grassrootsmapping/warpables/315614/IMAG0179_r_medium.JPG
@rexagod this may be a good one for you to take on so that your auto-stitching demos are also running on real aerial photos! cc @sashadev-sky (though after our export work!)
I'm so sorry! This is all good for the basic demo at index.html:
I was looking at a cached version (so frustrating!) due to an unrelated project. But the above still goes for the multiple select demo!
@jywarren I was going to fix this didn't forget about it! I was holding off a bit because I wanted to discuss with you why we are not using the recommended "google mutant layers" which would potentially end up changing the image we are using for the demo
I agree the current demo makes it pretty confusing what is going on with the combo of the map and image
No prob, just making sure I also didn't forget! Thanks!
On Mon, Jul 1, 2019, 6:21 PM Sasha Boginsky [email protected] wrote:
I agree the current demo makes it pretty confusing what is going on with the combo of the map and demo
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/315?email_source=notifications&email_token=AAAF6JYW22NFK67EQQFWPHLP5J7LBA5CNFSM4H4V47V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODY7QJUY#issuecomment-507446483, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J6X6KTU4Y6D6CSJXCDP5J7LBANCNFSM4H4V47VQ .
Ok cool! I sent you a slack message regarding the exporting in case you wanted to go through it again after the changes since I know it needs to be working asap @jywarren
@jywarren ok so did you want, when this is fixed, for the map to also be updated to Google Mutant Layers?
@jywarren Sure thing! I've replaced the older images with these in the demo. 👍
Great! We should be all good here now!
On Sun, Jul 7, 2019 at 8:06 AM Pranshu Srivastava [email protected] wrote:
@jywarren https://github.com/jywarren Sure thing! I've replaced the older images with these in the demo. 👍
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/315?email_source=notifications&email_token=AAAF6J5GZA4AKBEE5NMQPM3P6HLZNA5CNFSM4H4V47V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZLKGJA#issuecomment-508994340, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J3IWUOCJTAG4GCKXILP6HLZNANCNFSM4H4V47VQ .
@jywarren They are not updated for our demo? Did @rexagod mean his demo for the matcher? Also should I still open a PR to change the layers we use to google mutant layers?
+1 google mutant layers, i guess... it's a bit more visually noisy but more realistic!
I think I did update the demo -- https://publiclab.github.io/Leaflet.DistortableImage/examples/select do you not see them? Cache maybe? Thanks!
On Mon, Jul 8, 2019 at 8:08 PM Sasha Boginsky [email protected] wrote:
@jywarren https://github.com/jywarren They are not updated for our demo? Did @rexagod https://github.com/rexagod mean his demo for the matcher? Also should I still open a PR to change the layers we use to google mutant layers?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/issues/315?email_source=notifications&email_token=AAAF6JYNZGZVHTNPCNLREC3P6PJGXA5CNFSM4H4V47V2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZOWKXI#issuecomment-509437277, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JZXYMGEOPJ2ZM2FPWTP6PJGXANCNFSM4H4V47VQ .
@sashadev-sky I was referring to the matcher test case for stitcher. Sorry for any confusion!