Leaflet.DistortableImage icon indicating copy to clipboard operation
Leaflet.DistortableImage copied to clipboard

Working Rotate Gesture Pull

Open sashadev-sky opened this issue 5 years ago • 1 comments

Fixes #165 (<=== Add issue number here)

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

  • [ ] PR is descriptively titled 📑 and links the original issue above 🔗
  • [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt
  • [ ] code is in uniquely-named feature branch and has no merge conflicts 📁
  • [ ] screenshots/GIFs are attached 📎 in case of UI updates
  • [ ] @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

===========

pending:

  • use new rotation property tracking (added in #275) to debug a problem where image "stops rotating and bounces back"

  • update PR so that it has both the implementation using Hammer.js and no library if can't decide which one is better

  • clean up code / implementation. add to my demo page so jywarren can test easily.

  • Need to add a panTo so that if you try to rotate an image that is off screen a little bit, the screen will move so its not anymore or an error will be thrown.

===========

sashadev-sky avatar Jun 09 '19 06:06 sashadev-sky

@jywarren this is now working. Needs a lot of cleaning.. shouldn't all be inside of the load event of course and for testing purposes map moving is disabled. Need to add a panTo so that if you try to rotate an image that is off screen a little bit, the screen will move so its not anymore or an error will be thrown. The question is how would you like this to be implemented?

Is this for touch screens only? currently it works on both (click or touch and drag). Note there needs to be some sort of logic to separate moving the image from rotating it.

sashadev-sky avatar Jun 13 '19 01:06 sashadev-sky