Leaflet.DistortableImage icon indicating copy to clipboard operation
Leaflet.DistortableImage copied to clipboard

multiple image collection actions (like export)

Open jywarren opened this issue 10 years ago • 11 comments

Part 1: -- this part is done. This is becoming higher priority now, and would at most basic, include the ability to select and display as selected, multiple images.

Part 2: -- -- this part is done. We should be able to return an array of selected images, and to perform actions using their collected image URLs or other properties.

Part 3: -- this part is done. Eventually we should consider a menu for the manipulation of image collections, for example initiating an export. This relates to https://github.com/publiclab/mapknitter/issues/326, the new MapKnitter Exporter UI, but could also be used for simple things like dragging a group of images together.

Part 4: -- Open to claim Get all actions available in the single image interface working in the collection interface:

  • [x] Export
  • [x] Delete
  • [ ] ToggleTransparency
  • [ ] Restore
  • [ ] ToggleOutline
  • [ ] ToggleRotateScale
  • [ ] ToggleScale
  • [ ] ToggleRotate
  • [ ] EnableEXIF
  • [x] ToggleLock

jywarren avatar Jan 14 '15 23:01 jywarren

claiming this!

sashadev-sky avatar Feb 19 '19 14:02 sashadev-sky

@jywarren hey just wanted to provide a status update here! Working on this and hoping to open a pull request tonight. Thank you

sashadev-sky avatar Feb 25 '19 14:02 sashadev-sky

Amazing!!!!

jywarren avatar Feb 27 '19 23:02 jywarren

@jywarren I updated this issue a little please feel free to revert it if you think it shouldn't be updated that way

sashadev-sky avatar Mar 31 '19 01:03 sashadev-sky

OK! We've ironed out the input format for both the Ruby and JS based exporters, documented here:

https://github.com/publiclab/mapknitter-exporter-sinatra/pull/1#issuecomment-478173823

And we'll also need some glue function to convert that into the JS-specific format here (although we can do that as a follow-up step!):

https://github.com/publiclab/image-sequencer-app/issues/6#issuecomment-478205417

This is all coming together!

jywarren avatar Apr 01 '19 15:04 jywarren

We could aim for a function that outputs the basic JSON format in https://github.com/publiclab/mapknitter-exporter-sinatra/pull/1#issuecomment-478173823, called collection.getExportJson()?

jywarren avatar Apr 01 '19 15:04 jywarren

This would eventually be replaced/superceded by a fuller Export UI in React that @sashadev-sky has explored!

jywarren avatar Apr 01 '19 15:04 jywarren

This is great. The new class -- was it FeatureCollection? -- is there an accessor function like featureCollection.getFeatures that would return an array we could iterate over?

jywarren avatar Apr 01 '19 15:04 jywarren

Class is called L.DistortableCollection. The Leaflet way of doing this is this.eachLayer(function(layer) { .... });. Not entirely convenient so I can save create quick PR for accessor function. Going to start the project first, though. Does that work?

sashadev-sky avatar Apr 03 '19 02:04 sashadev-sky

Yeah, perfect!!!

jywarren avatar Apr 05 '19 18:04 jywarren

@jywarren made some updates here!

sashadev-sky avatar Jul 02 '19 01:07 sashadev-sky