Leaflet.DistortableImage
Leaflet.DistortableImage copied to clipboard
publiclab
Implement dynamic sub-menus
Fixes #207. Static implementation. Tests and dynamic implementations will be in a followup PR, as per @jywarren's suggestion.
/cc @jywarren @sashadev-sky
Noting that I haven't forgotten about this one - but before reviewing this i'd like to address the questions I brought up in https://github.com/publiclab/Leaflet.DistortableImage/pull/169 and maybe get that merged 1st, because it discusses file structure
@sashadev-sky @jywarren I've shared some thoughts on #169, and meanwhile we're discussing there can we progress things here (reviews, etc.) and get this upto speed to a point when only merging is left? I guess that'd be more convenient, and any little adjustments in this PR can be easily made later on. Thanks!
That would be great @rexagod -- i'm eager to get this integrated. Will the rebase here be difficult? Shall we start there, and I'll comment on #169 so we can move here next?
@jywarren @sashadev-sky Can you let me know which icons do you think should I send to the sub-menu? Also @sashadev-sky can you link me to the svg source so I can fetch an appropriate icon for the sub-menu? Thanks!
Great idea. Let's aim for a bulleted list with subitems here as our
discussion phase. Sasha, maybe you first? Or Pranshu if you want to post a
suggested nesting first? I think let's aim to have 4-6 critical tools and
the remainder under a ... "more tools" menu?
Thanks!
On Fri, Jul 26, 2019 at 1:39 PM Pranshu Srivastava [email protected] wrote:
@jywarren https://github.com/jywarren Can you let me know which icons do you think should I send to the sub-menu? Also @sashadev-sky https://github.com/sashadev-sky can you link me to the svg source so I can fetch an appropriate icon for the sub-menu? Thanks!
[image: image] https://user-images.githubusercontent.com/33557095/61970263-0a3d8700-affa-11e9-9704-1d71075deb99.png
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/225?email_source=notifications&email_token=AAAF6JZB3OBGH3NYK6I3PZTQBMZERA5CNFSM4HHFGHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD25ICVY#issuecomment-515539287, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J6RN5RN47MDSWWERE3QBMZERANCNFSM4HHFGHAA .
@jywarren I guess an optimal approach here would be to keep the most frequently/important 3 or 4 icons out of the submenu while grouping the other ones. So, I'm guessing,
- Delete
- EXIF
- Revert
- Export
could go inside the submenu. What do you think?
I like it!
On Fri, Jul 26, 2019 at 6:14 PM Pranshu Srivastava [email protected] wrote:
@jywarren https://github.com/jywarren I guess an optimal approach here would be to keep the most frequently/important 3 or 4 icons out of the submenu while grouping the other ones. So, I'm guessing,
- Delete
- EXIF
- Revert
- Export
could go inside the submenu. What do you think?
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/225?email_source=notifications&email_token=AAAF6J3ZLW6L74D7EBE74RLQBNZIRA5CNFSM4HHFGHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD252RYY#issuecomment-515614947, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6J7EUBUO2QYGSGTZOMDQBNZIRANCNFSM4HHFGHAA .
Hello guys,
nice idea and work. I will add one suggestion:
A menu option with sub-menus selectors for each mode, to direct change to desired mode ;)
+1 to the mode idea thank you @themacboy!! I have been trying to figure out ways to clarify that modes are like special actions
@rexagod @jywarren I am thinking that submenus should be for related tools because they imply some sort of categorization / relationship right?, like the modes idea suggested by @themacboy. For extra tools, it would be cool maybe to have them in a little box kinda similar to the way rexagod and I made this keymapper:
and you can drag them and replace them with current toolbar icons. It seems difficult but now that we have the code down for making said little box were not that far away from having that right?? Or like to start something as simple as double-clicking them makes them swap out based on LIFO or something
I like the idea of related tools. However, for an initial implementation, just to get the basic goal of "reduce overwhelming # of tools at first glance", I think it's OK to have a final menu item of "..." which contains any tool that's not super critical. Then we can follow up with some other menu organization tactics!
On Tue, Jul 30, 2019 at 6:51 AM Sasha Boginsky [email protected] wrote:
@rexagod https://github.com/rexagod @jywarren https://github.com/jywarren I am thinking that submenus should be for related tools because they imply some sort of categorization / relationship right?, like the modes idea suggested by @themacboy https://github.com/themacboy. For extra tools, it would be cool maybe to have them in a little box kinda similar to the way I made this keymapper:
[image: 62043675-ef703b80-b1ce-11e9-94f8-b8854446a08e] https://user-images.githubusercontent.com/41092741/62123035-09745180-b295-11e9-9bef-b41beb5a98f7.gif
and you can drag them and replace them with current toolbar icons. It seems difficult but now that we have the code down for making said little box were not that far away from having that right?? Or like to start something as simple as double-clicking them makes them swap out based on LIFO or something
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/publiclab/Leaflet.DistortableImage/pull/225?email_source=notifications&email_token=AAAF6J6JXPFIHFM7DYZEOOTQCAMH7A5CNFSM4HHFGHAKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3DSRBI#issuecomment-516368517, or mute the thread https://github.com/notifications/unsubscribe-auth/AAAF6JZ6FUKJPWUNL5MDMFLQCAMH7ANCNFSM4HHFGHAA .