MapKnitter Lite: fetch images from Internet Archive #998

[AndroGenius-codes]

Fixes #998 (<=== Add issue number here) drag and drop feature.webm

Make sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!

• [x] PR is descriptively titled 📑 and links the original issue above 🔗
• [x] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with grunt test
• [ ] code is in uniquely-named feature branch and has no merge conflicts 📁
• [x] screenshots/GIFs are attached 📎 in case of UI updates
• [x] @mention the original creator of the issue in a comment below for help or for a review

We're happy to help you get this ready -- don't be afraid to ask for help, and don't be discouraged if your tests fail at first!

If tests do fail, click on the red X to learn why by reading the logs.

Please be sure you've reviewed our contribution guidelines at https://publiclab.org/contributing-to-public-lab-software

Thanks!

[gitpod-io[bot]]

[AndroGenius-codes]

@cesswairimu @TildaDares @jywarren can review my code and tell me if it fixes the drag and drop feature in issue #998 if it doesn't what can i do to improve it

[AndroGenius-codes]

Untitled_ Oct 19 2022 10_13 AM.webm

i made the changes to the archive.html file and deleted the changes i made previously to export.html. does this look like what you were talking about @jywarren @TildaDares

[7malikk]

@AndroGenius-codes Great work so far, if you're willing to finish this up, I believe the final touches would be to update the archive.html file as it has undergone some recent changes and integrate your implementation with the already existing code.

@jywarren what are your thoughts on this implementation?

[jywarren]

Hi all, I like this a lot. However it does introduce some UI complexity that I want to think through carefully.

1. I think we should put the warning "you'll need to upload these to Archive.org" in the sidebar by the upload button, in addition to in the alert
2. we should specify (in both places) that the images won't be preserved if the page is closed or refreshed
3. but by introducing this "upload" button, are we potentially confusing people as to the workflow? If they should be uploading to Archive.org, should we not even offer them the option of uploading here?

What are some other options? Could we call this a "temporary map" and store it in a different html file, which we link to? What is the use case -- if someone wants to work privately, say? And we should make it clear there is no full-map exporting if you do this, since the files aren't stored online. Let's talk through some of the issues here, what the exact use case and goal is, and that can guide what we do here.

I do want to say it's very well implemented. It looks great. I just want to be thoughtful about what this presents to the user and if it makes sense or complicates the workflow. Thanks all!

Moving to #1236

[7malikk]

Hi all, I like this a lot. However it does introduce some UI complexity that I want to think through carefully.

1. I think we should put the warning "you'll need to upload these to Archive.org" in the sidebar by the upload button, in addition to in the alert
2. we should specify (in both places) that the images won't be preserved if the page is closed or refreshed
3. but by introducing this "upload" button, are we potentially confusing people as to the workflow? If they should be uploading to Archive.org, should we not even offer them the option of uploading here?

What are some other options? Could we call this a "temporary map" and store it in a different html file, which we link to? What is the use case -- if someone wants to work privately, say? And we should make it clear there is no full-map exporting if you do this, since the files aren't stored online. Let's talk through some of the issues here, what the exact use case and goal is, and that can guide what we do here.

I do want to say it's very well implemented. It looks great. I just want to be thoughtful about what this presents to the user and if it makes sense or complicates the workflow. Thanks all!

@jywarren, It's like you read my mind, especially in regard to the workflow. Also about storage in a different html file, I believe you and @AndroGenius-codes had come to this conclusion earlier and he reworked it in #1236 I noticed something of that sorts while i was going through the PRs.

We should check it out and maybe work up from there as it is also a very good work by @AndroGenius-codes